Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTS Tuning with Ch2Ch3 mode #7202

Closed
baconpaul opened this issue Aug 26, 2023 · 0 comments · Fixed by #7270
Closed

MTS Tuning with Ch2Ch3 mode #7202

baconpaul opened this issue Aug 26, 2023 · 0 comments · Fixed by #7270
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme MIDI MIDI support related MPE MIDI Polyphonic Expression related issues
Milestone

Comments

@baconpaul
Copy link
Collaborator

Right now SurgeVoice::getPitch does this

 keyRetuning = MTS_RetuningInSemitones(storage->oddsound_mts_client, key + mpeBend, 0);

the reason for that hardcoded channel 0 is two fold

  1. In MPE mode its really what you want. Really.
  2. Outside MPE mode surge uses channel 2 and 3 for scene individuation. And so its what you want

But we now have a no-more-ch23-mode-switch. Fine.

So that 0 should really be

(23mode || mpemode || chsplit scene mode) ? 0 : channel

but that conditional is a bit tricky. We don't want to call SurgeStorage::getPreference there - it is called on every voice on every block. So need to set up that condition at voice on as a bool and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme MIDI MIDI support related MPE MIDI Polyphonic Expression related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants