Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe a parallel releaseNoteById()? #7184

Closed
baconpaul opened this issue Aug 13, 2023 · 1 comment · Fixed by #7190
Closed

maybe a parallel releaseNoteById()? #7184

baconpaul opened this issue Aug 13, 2023 · 1 comment · Fixed by #7190
Labels
Feature Request New feature request MIDI MIDI support related
Milestone

Comments

@baconpaul
Copy link
Collaborator

No description provided.

@baconpaul baconpaul added the Feature Request New feature request label Aug 13, 2023
@baconpaul baconpaul added this to the Surge XT 1.3 milestone Aug 13, 2023
@mkruselj mkruselj added the MIDI MIDI support related label Aug 14, 2023
@baconpaul
Copy link
Collaborator Author

So late last night it became clear to me how to do this since note id to voice isn’t 1:1

basicalky

array uint16 done [128]
for v : voices
If match
Done[v key] |= 1<<v channel

For d in done
If d
Release appropatelg

that will stop the iteration modifying voices while going with basically a read pass and write pass

will do later this week just want to memorialize

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 18, 2023
Mostly to make Phil's live easier with OSC. But it seems
like a handy option.

Closes surge-synthesizer#7184
baconpaul added a commit that referenced this issue Aug 18, 2023
* Add 'removeByHostNoteID' method to SurgeSynthesizer

Mostly to make Phil's live easier with OSC. But it seems
like a handy option.

Closes #7184

* rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request MIDI MIDI support related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants