Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feedback in Sin/FM2/FM3 is... #7152

Closed
Andreya-Autumn opened this issue Aug 9, 2023 · 1 comment · Fixed by #7153
Closed

New feedback in Sin/FM2/FM3 is... #7152

Andreya-Autumn opened this issue Aug 9, 2023 · 1 comment · Fixed by #7153
Labels
Discussion Experimental Issues related to experimental features that may or may not see the light of day FM Enhancements
Milestone

Comments

@Andreya-Autumn
Copy link
Collaborator

...correct? Borked? Hard to say.

But this is true: (sine old fb x) - (sin new fb 2 x) = 0
Or in other words the new one gives exactly the same result as the old at half the percent value.

In FM2 and 3 this is not true. The new and old modes never subtract to silence.

Investigation needed.

@Andreya-Autumn Andreya-Autumn added FM Enhancements Experimental Issues related to experimental features that may or may not see the light of day Discussion labels Aug 9, 2023
@Andreya-Autumn Andreya-Autumn added this to the Surge XT 1.3 milestone Aug 9, 2023
@Andreya-Autumn
Copy link
Collaborator Author

Some more digging later: In FM2/3, the new and old modes diverge more and more the higher the percent. Same percent is always closest to a null, but at 50 they null to about -50 dB, at 100 only to -12, and once you get noisy they differ too much to null at all.

Sine doesn't seem to do that.

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 9, 2023
1. Actually store last value 0 (duh) and
2. apply the squaring etc at the same place as FM2

Closes surge-synthesizer#7152
baconpaul added a commit that referenced this issue Aug 9, 2023
1. Actually store last value 0 (duh) and
2. apply the squaring etc at the same place as FM2

Closes #7152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Experimental Issues related to experimental features that may or may not see the light of day FM Enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant