Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tuning Editor functionality in MTS Client Mode #7146

Closed
tank-trax opened this issue Aug 8, 2023 · 1 comment · Fixed by #7162
Closed

Tuning Editor functionality in MTS Client Mode #7146

tank-trax opened this issue Aug 8, 2023 · 1 comment · Fixed by #7162
Labels
Feature Request New feature request Tuning Non-standard tuning extensions
Milestone

Comments

@tank-trax
Copy link
Collaborator

Currently if Surge is in MTS-ESP client mode the Tuning Editor is dormant and not reading data

The request is to have Radial and True Keys provide scale information as it would if Surge was playing from a loaded .scl file

As per our discussion on Discord:

True Keys display would require:

1: The currently pressed keys
2: Their frequency
3: The ability to subtract and take a log

*Since we show actual keys not scale tones. We have all of that in MTS mode

The Radial display would require:

1: The currently pressed key
2: The scale tone for each of those keys
3: The repetition interval of the scale
4: Their frequency
5: The ability to subtract and take a log

*We are missing 2 and 3 in the MTS api but have it in the tuning library

@tank-trax tank-trax added the Feature Request New feature request label Aug 8, 2023
@tank-trax tank-trax added this to the Surge XT 1.3 milestone Aug 8, 2023
@baconpaul
Copy link
Collaborator

Yup. So basically this amounts to

  1. In MTSmode enable the tuning editor menu but
  2. Have the SCL/KBM, Interval and Radial tabs not available
  3. Just show tru interval and the side keyboard

@mkruselj mkruselj added the Tuning Non-standard tuning extensions label Aug 9, 2023
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 10, 2023
In MTS-ESP mode you can use a subset of the tuning editor
so rename it tuning visualizer in that mode and show the true
keys and the keyboard display

Closes surge-synthesizer#7146
baconpaul added a commit that referenced this issue Aug 10, 2023
In MTS-ESP mode you can use a subset of the tuning editor
so rename it tuning visualizer in that mode and show the true
keys and the keyboard display

Closes #7146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request Tuning Non-standard tuning extensions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants