Clicks n Pops Master Issue

[baconpaul]

Just having a master issue for all the clicks n pops reporting we have. I have an update in a second on some thoughts.

[baconpaul]

OK so my first thought on clicks-n-pops is that something must be uninitialized, reads random memory, and then outputs garbage to the sound channel.

So I bit the bullet and set up surge so I could actually play notes on an on screen keyboard while it was running in valgrind. For other intrepid folks, here's how

sudo apt-get install jack
sudo apt-get install jack-keyboard
sudo apt-get install ajmidid

(in one terminal)

jack -d alsa -X alsa_midi

(in another terminal)

ajmidid -e

(in a third terminal)

sudo apt-get install jack

(in a fourth terminal)

jack-keyboard

once surge has started jack keyboard should have a 'connected to' option for surge in. Pick it and press a note and surge will play. Useful.

When you do that, on linux you see lots and lots of jmps on uninitialized reads, some in the filters.

out.valgrnd.gz

[baconpaul]

Oh and that's just from playing a single note in the init patch. I'm sure other reports in the clicks n pop family have similar problems in other spots.

[baconpaul]

Linking #710 here also