Editor Undo/Redo #694

baconpaul · 2019-03-02T13:13:56Z

OK tackle this so here's the checklist. As always items on the list without a check are known and not done; items with a check are in a branch which isn't merged or pr yet

Undo accessibility and announcements
Undoable action clears redo stack

Would be great if the synth had undo/redo for edits. from
https://www.kvraudio.com/forum/viewtopic.php?p=7330177#p7330177

j5v · 2020-07-29T22:53:51Z

Came to post, but found this issue was already here.

Undo and Redo could go next to Store in the UI.
Storage: happy with session persistence only.
When to store:
- on data entry,
- on mouse up on slider, or
- 2s delay after scroll action, or overwrite the last history state if changing the same parameter again.
Keyboard shortcuts: use Ctrl/Cmd+Z and Ctrl/Cmd+Y (or Shift+Ctrl/Cmd+Z), preventing pass-thru to host.

mkruselj · 2021-03-18T13:06:29Z

Keyboard shortcuts: use Ctrl/Cmd+Z and Ctrl/Cmd+Y (or Shift+Ctrl/Cmd+Z), preventing pass-thru to host.

Unfortunately this one would not be happening, as dealing with keyboard events in all the various DAWs is just a humongous pain in the ass (and sometimes just doesn't work no matter what anyways)

mkruselj · 2022-03-31T19:05:08Z

Apparently, moving to XT 1.1 milestone. 🥳

This is a basic infrastucture which moves us towards undo in an editor. Lots missing here all detailed in a checklist in surge-synthesizer#694 but with this commit parameter changes, modulation changes, osc and fx changes all push into the undo stack

This is a basic infrastucture which moves us towards undo in an editor. Lots missing here all detailed in a checklist in surge-synthesizer#694 but with this commit parameter changes, modulation changes, osc and fx changes all push into the undo stack. Use a simple limit of 250 gestures per instance captured.

This is a basic infrastucture which moves us towards undo in an editor. Lots missing here all detailed in a checklist in #694 but with this commit parameter changes, modulation changes, osc and fx changes all push into the undo stack. Use a simple limit of 250 gestures per instance captured.

mkruselj · 2022-04-02T11:38:58Z

"Undo changes" action shows both on top and on bottom of Edit Keybindings overlay.
Redo action?

baconpaul · 2022-04-02T12:15:54Z

Ahh I forgot about redo. Will add this week before I add more undoables

Add redo support - Params can redo - Redo for Modulations - FX and OSC work - Stack dump useful and in dev menu Addresses surge-synthesizer#694

Add redo support - Params can redo - Redo for Modulations - FX and OSC work - Stack dump useful and in dev menu - Debug build label moves and dev menu on Addresses surge-synthesizer#694

Add redo support - Params can redo - Redo for Modulations - FX and OSC work - Stack dump useful and in dev menu - Debug build label moves and dev menu on Addresses #694

Addresses surge-synthesizer#694 - Step Sequencer undo

Step Sequencer Udno. Also lays out the pattern for the other compound types. Addresses surge-synthesizer#694

Step Sequencer Udno. Also lays out the pattern for the other compound types. Addresses #694

- Swap LFO display on LFO undo - Rename LFO and Macro - Macro Values - LFO Type Undo/Redo - Modulation List Gestures in Undo/Redo - An Undo/Redo button Addresses surge-synthesizer#694

Right click on undo/redo shows context menu with link to manual and entry to open Action History overlay Implement scaffolding for Action History overlay Remove unnecessary break statements in createOverlay() method Hovers are not displayed for Switches if they're deactivated Add new assets to SkinImageMaps res[] array Last but not the least, do a tiny bit of renaming for AW Cabs Addresses surge-synthesizer#694

* Finalize undo history assets and more Right click on undo/redo shows context menu with link to manual and entry to open Action History overlay Implement scaffolding for Action History overlay Remove unnecessary break statements in createOverlay() method Hovers are not displayed for Switches if they're deactivated Add new assets to SkinImageMaps res[] array Last but not the least, do a tiny bit of renaming for AW Cabs Addresses #694

Addresses surge-synthesizer#694 - Modulator mute undoes - Modulator menu items work - MSEG

Addresses #694 - Modulator mute undoes - Modulator menu items work - MSEG

Addresses surge-synthesizer#694

Addresses #694

UI gestores which change tuning (drag and drop and editor) participate in undo/redo Addresses surge-synthesizer#694

UI gestores which change tuning (drag and drop and editor) participate in undo/redo. Applying a Formula puts it in the undo stack (but the code editor component eats Ctrl-Z for micro changes so it is subtle). Addresses surge-synthesizer#694 f

UI gestores which change tuning (drag and drop and editor) participate in undo/redo. Applying a Formula puts it in the undo stack (but the code editor component eats Ctrl-Z for micro changes so it is subtle). Addresses #694

- Redo/Undo through patch changes Addresses surge-synthesizer#694

- Redo/Undo through patch changes - Have an approximate undo/redo memory threshold - Trip undo/redo based on being over thresholds - Cleanup memory here and there from the patch thing Addresses surge-synthesizer#694

- Redo/Undo through patch changes - Have an approximate undo/redo memory threshold - Trip undo/redo based on being over thresholds - Cleanup memory here and there from the patch thing Addresses #694

1. Parameter temposync etc 2. Full LFO on LFO menu reset Addresses surge-synthesizer#694

1. Parameter temposync etc 2. Full LFO on LFO menu reset Addresses #694

So do do undo undo redo -> stack OK do do undo newdo -> redostack clear Addreses surge-synthesizer#694

So do do undo undo redo -> stack OK do do undo newdo -> redostack clear Addreses #694

Closes surge-synthesizer#694

Closes #694

baconpaul added the Feature Request New feature request label Mar 2, 2019

baconpaul added this to the 1.6.n milestone Mar 2, 2019

baconpaul changed the title ~~Undo/Redo~~ Editor Undo/Redo Mar 2, 2019

baconpaul modified the milestones: 1.6.n, Currently Unscheduled Oct 4, 2019

mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Feb 5, 2020

mkruselj added the Design Required We need to design a solution to this issue label Sep 21, 2021

mkruselj mentioned this issue Nov 23, 2021

UI indication for Selected Waveform Classic/Modern #5439

Open

mkruselj modified the milestones: Currently Unscheduled, Surge XT 1.1 Mar 31, 2022

baconpaul mentioned this issue Apr 1, 2022

Move towards editor undo #6004

Merged

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 6, 2022

Redo Support

63dc69d

Add redo support - Params can redo - Redo for Modulations - FX and OSC work - Stack dump useful and in dev menu Addresses surge-synthesizer#694

baconpaul mentioned this issue Apr 6, 2022

Redo Support #6026

Merged

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 6, 2022

Redo Support

034f586

Add redo support - Params can redo - Redo for Modulations - FX and OSC work - Stack dump useful and in dev menu - Debug build label moves and dev menu on Addresses surge-synthesizer#694

baconpaul added a commit that referenced this issue Apr 6, 2022

Redo Support (#6026)

94fa4c7

Add redo support - Params can redo - Redo for Modulations - FX and OSC work - Stack dump useful and in dev menu - Debug build label moves and dev menu on Addresses #694

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 7, 2022

More Undo/Redo capabilities

78a6bce

Addresses surge-synthesizer#694 - Step Sequencer undo

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 7, 2022

Step Sequencer Undo

089cf90

Step Sequencer Udno. Also lays out the pattern for the other compound types. Addresses surge-synthesizer#694

baconpaul mentioned this issue Apr 7, 2022

Step Sequencer Undo #6032

Merged

baconpaul added a commit that referenced this issue Apr 7, 2022

Step Sequencer Undo (#6032)

dced24f

Step Sequencer Udno. Also lays out the pattern for the other compound types. Addresses #694

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 7, 2022

More Undo Changes

9d6b51a

- Swap LFO display on LFO undo - Rename LFO and Macro - Macro Values - LFO Type Undo/Redo - Modulation List Gestures in Undo/Redo - An Undo/Redo button Addresses surge-synthesizer#694

mkruselj mentioned this issue Apr 9, 2022

Finalize undo history assets and more #6039

Merged

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 10, 2022

Yet more undo work

5384235

Addresses surge-synthesizer#694 - Modulator mute undoes - Modulator menu items work - MSEG

baconpaul mentioned this issue Apr 10, 2022

Yet more undo work #6044

Merged

baconpaul added a commit that referenced this issue Apr 10, 2022

Yet more undo work (#6044)

e4dcf9e

Addresses #694 - Modulator mute undoes - Modulator menu items work - MSEG

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 11, 2022

Make sure undone element is focused in the UI

bf8ff91

Addresses surge-synthesizer#694

baconpaul mentioned this issue Apr 11, 2022

Make sure undone element is focused in the UI #6048

Merged

baconpaul added a commit that referenced this issue Apr 11, 2022

Make sure undone element is focused in the UI (#6048)

38f7144

Addresses #694

mkruselj added the Before Beta If these are open we can't really call ourselves beta label Apr 18, 2022

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 22, 2022

Tuning Editor Undo Redo

db1c846

UI gestores which change tuning (drag and drop and editor) participate in undo/redo Addresses surge-synthesizer#694

baconpaul mentioned this issue Apr 22, 2022

Tuning Editor and Formula Undo Redo #6075

Merged

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 22, 2022

Patch Undo and Redo/Undo Cleanup

f1e5847

- Redo/Undo through patch changes Addresses surge-synthesizer#694

baconpaul mentioned this issue Apr 23, 2022

Patch Undo and Redo/Undo Cleanup #6076

Merged

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 23, 2022

Final undo gestures on stack

aab7c06

1. Parameter temposync etc 2. Full LFO on LFO menu reset Addresses surge-synthesizer#694

baconpaul mentioned this issue Apr 23, 2022

Final undo gestures on stack #6077

Merged

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 23, 2022

Final undo gestures on stack

e0d5f0b

1. Parameter temposync etc 2. Full LFO on LFO menu reset Addresses surge-synthesizer#694

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 23, 2022

Final undo gestures on stack

7cbfde9

1. Parameter temposync etc 2. Full LFO on LFO menu reset Addresses surge-synthesizer#694

baconpaul added a commit that referenced this issue Apr 23, 2022

Final undo gestures on stack (#6077)

8f2956b

1. Parameter temposync etc 2. Full LFO on LFO menu reset Addresses #694

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 23, 2022

Clear Redo stack when doing undoable UI event

e47bd22

So do do undo undo redo -> stack OK do do undo newdo -> redostack clear Addreses surge-synthesizer#694

baconpaul mentioned this issue Apr 23, 2022

Clear Redo stack when doing undoable UI event #6078

Merged

baconpaul added a commit that referenced this issue Apr 23, 2022

Clear Redo stack when doing undoable UI event (#6078)

7d2c606

So do do undo undo redo -> stack OK do do undo newdo -> redostack clear Addreses #694

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 23, 2022

Announce undo actions with Accessible reader

d3bbcab

Closes surge-synthesizer#694

baconpaul mentioned this issue Apr 23, 2022

Announce undo actions with Accessible reader #6079

Merged

baconpaul closed this as completed in #6079 Apr 23, 2022

baconpaul added a commit that referenced this issue Apr 23, 2022

Announce undo actions with Accessible reader (#6079)

61b9672

Closes #694

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Editor Undo/Redo #694

Editor Undo/Redo #694

baconpaul commented Mar 2, 2019 •

edited

Loading

j5v commented Jul 29, 2020

mkruselj commented Mar 18, 2021

mkruselj commented Mar 31, 2022

mkruselj commented Apr 2, 2022 •

edited by baconpaul

Loading

baconpaul commented Apr 2, 2022

Editor Undo/Redo #694

Editor Undo/Redo #694

Comments

baconpaul commented Mar 2, 2019 • edited Loading

j5v commented Jul 29, 2020

mkruselj commented Mar 18, 2021

mkruselj commented Mar 31, 2022

mkruselj commented Apr 2, 2022 • edited by baconpaul Loading

baconpaul commented Apr 2, 2022

baconpaul commented Mar 2, 2019 •

edited

Loading

mkruselj commented Apr 2, 2022 •

edited by baconpaul

Loading