Keybinding accessibility

[baconpaul]

reported by bscross on discord

There are 3 unlabeled buttons in the shortcut editor. They are at the very end of the list, though this doesn't mean they are there visually. Consequently, when I set things here, they do not take past the session. I think I saw that there's supposed to be a CTRL+0 keybind for speaking various info, but it does nothing for me.

I went in there to bind the initialize patch key. It lasted the session but then when Surge is loaded again, it's gone. I did the same thing, set it, lasts for the session, then gone. So repeated the procedure twice.

[ironcross32]

Version: 1.2.nightly.97ccf6d

Using CLAP

[mkruselj]

These buttons seem to be just the same bypass/learn/reset buttons that all other keybind assignments have, except they are scrolled off-viewport, but somehow still visible for a11y... I wonder if this is maybe a bug somewhere in juce::ListBox...

EDIT: Now listening with Narrator... Yeah the scroll position of the list box/which controls are actually visible is not taken into account when specifying a11y names of controls. So maybe it's not a bug in juce::ListBox then? @baconpaul Thoughts?

[mkruselj]

This GIF should show the issue better perhaps:

[baconpaul]

I'm pretty sure the accessible view has the entire list. The scrollbar is a visual only construct. Is that not what you see?

[baconpaul]

Are the OK/Cancel/Reset buttons labeled properly?

[ironcross32]

No. I can OCR two of the three, one is cancel, the other is reset. The one far left with screen reader is probably OK. There is a labeled close button though. When this is fixed, this will resolve the settings don't take part of this issue because I'm imagining the close button isn't saving the new settings.

[mkruselj]

The Close button is not supposed to store the keybinding changes, the OK button is.

[mkruselj]

So I noticed that the 4 controls on the bottom weren't fully accessible, they didn't speak out their names at all either. So I fixed that, the next nightly version (in 45-ish minutes or so) should have this change.

[mkruselj]

@ironcross32 Do let us know if this is sufficient to consider this issue closed or not, after you check it out!

[ironcross32]

Will do.

[ironcross32]

Issues resolved.

[mkruselj]

Waheeeeey! Thanks for feedback!

[baconpaul]

Awesome!