Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ponder LFO EG sustain behavior on modulation #6874

Open
Andreya-Autumn opened this issue Mar 5, 2023 · 0 comments
Open

Ponder LFO EG sustain behavior on modulation #6874

Andreya-Autumn opened this issue Mar 5, 2023 · 0 comments
Labels
Breaking Change In order to close this issue we need to make a breaking change (no backwards compatibility) Discussion Modulation Modulation related issues
Milestone

Comments

@Andreya-Autumn
Copy link
Collaborator

Andreya-Autumn commented Mar 5, 2023

As of 1.2, EG sustain params behave in two ways:

LFOEG's can not have sustain modulated during the sustain phase. Modulation will be in effect during decay, as the decay approaches the moving target, but once sustain phase begins the value is held as discussed here: surge-synthesizer/surge-rack#858

FEG and AEG can have sustain modulated, also once the sustain phase begins. The modulation is slew-limited by the decay rate parameter though. EvilDragon points out that this is probably congruent with many analog designs (in which decay may quite literally be a slew limiter on sustain value), but I don't know if this is expected behavior in a digital synth like Surge.

Changes here would be breaking obviously. So for XT2:

A: Decide on what behavior we would really want.
B: Make sure that behavior is consistent across AEG/FEG/LFOEG

@Andreya-Autumn Andreya-Autumn added Modulation Modulation related issues Discussion Breaking Change In order to close this issue we need to make a breaking change (no backwards compatibility) labels Mar 5, 2023
@Andreya-Autumn Andreya-Autumn added this to the Surge XT 2.0 milestone Mar 5, 2023
@mkruselj mkruselj changed the title Ponder EG sustain behavior on modulation Ponder LFO EG sustain behavior on modulation Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change In order to close this issue we need to make a breaking change (no backwards compatibility) Discussion Modulation Modulation related issues
Projects
None yet
Development

No branches or pull requests

1 participant