LFOEG Sustain Not Modulatable during Gate After Decay

[Andreya-Autumn]

If changes and modulations to EG params were applied in continuously on the LFOxEG out, that would allow some cool modulations, plus make LFOxEG interactions easier to understand! For now, the EG params only update at each trig.

[baconpaul]

Sigh. So the problem here is a bit more subtle.

The AHDRS are snapped when modulated and are passed in. you can see this by setting a long attack and modulating it with a high frequency lfo and it wiggles as it goes up

The problem is the surge LFO sustain phase gets to the release point at the end of the decay phase and holds that constant.

You can see this in the VST. If you set up an envelope and have LFO2 -> LFO1 sustain, apply LFO1 to pitch and have a long decay and a fast LFO2 you can hear the system wobbling as the decay happens - the target is shifting - but once the decay time ends and you get to the sustain the modulation doesn't impact the sustain curve.

We could change that but it's a breaking change for surge so needs a switch and so on.

So for now I'm going to rename this issue to be more accurate ("Sustain Not Modulatable when gated after decay") and move it out of 2.1.4.

[baconpaul]

Ahh I should have looked at this earlier in S13 cycle; i don't want to screw with the LFO in surge proper so I'm going to knock this out of 22 milestone also. We should bring both issues into a current milestone earlier.