Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display version reporting error #6839

Closed
Andreya-Autumn opened this issue Feb 6, 2023 · 1 comment · Fixed by #6851
Closed

Display version reporting error #6839

Andreya-Autumn opened this issue Feb 6, 2023 · 1 comment · Fixed by #6851
Labels
Bug Report Item submitted using the Bug Report template Infrastructure Issues related to repository, CI/CD, installers, etc.
Milestone
Surge XT 1.2

Comments

@Andreya-Autumn
Copy link
Collaborator

"Surge XT 1.1.2.d3568a9 is installed but the plugin is reporting Version 1.1.0 to the host. In the About dialog, the version is ok"
@Andreya-Autumn Andreya-Autumn added the Bug Report Item submitted using the Bug Report template label Feb 6, 2023
@Andreya-Autumn Andreya-Autumn added this to the Surge XT 1.2 milestone Feb 6, 2023
@baconpaul
Copy link
Collaborator

This by the way is because the version in the top of the cmake bakes into the dll in juce - I just need to remember to manually change it on release or fail ci if it doesn’t match

@mkruselj mkruselj added the Infrastructure Issues related to repository, CI/CD, installers, etc. label Feb 7, 2023
mkruselj added a commit to mkruselj/surge that referenced this issue Feb 18, 2023
@mkruselj
Update version to 1.2.0 in CMake
92323be 
Closes surge-synthesizer#6839
@mkruselj mkruselj mentioned this issue Feb 18, 2023
Merged
mkruselj added a commit that referenced this issue Feb 18, 2023
@mkruselj
Update version to 1.2.0 in CMake (#6851)
b991f82 
Closes #6839
This was referenced Mar 5, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Infrastructure Issues related to repository, CI/CD, installers, etc.
Projects
None yet
Milestone
Surge XT 1.2
Development

Successfully merging a pull request may close this issue.

Update version to 1.2.0 in CMake mkruselj/surge
3 participants
@mkruselj @baconpaul @Andreya-Autumn