-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale LFO/EG separate outputs by amplitude optionally #6674
Comments
Agree, both seem good. |
So I have this coded but @mkruselj and @Andreya-Autumn an opinion Should this setting/option be per LFO or per patch. I have coded it as per LFO but that makes it hard to change an entire patch. Everything else (default, scale, extend, option) works without problem. But as I was going to write the streaming code I thought: do I want to stream this 12 times or 1? I have my code stashed away in baconpaul/lfo-scale-6674 and once we decide above it is 30 minutes to close this issue My gut is "per patch" is right. |
It should per LFO IMO. Maybe with an option to apply current setting to all LFOs in the scene (not the patch). Just like how we deal with temp sync on envs. |
Agreed. Default to on, turn-offable per LFO seems best to me. |
It should default to off to retain existing behavior. |
Is that necessary you think? It should be off for saved patches obviously. But beyond that I'm not sure we need to stay consistent here. |
We should for the XT1 cycle at least. We did so far for pretty much all other cases, always kept existing behavior as default. |
We didn't for the mono retrig-from-current behavior, but admittedly the new behavior is more obviously "better" in that case. |
Allow users to toggle raw outputs scaled by amplitude on an LFO-by-LFO basis in the hamburger menu. Closes surge-synthesizer#6674
Allow users to toggle raw outputs scaled by amplitude on an LFO-by-LFO basis in the hamburger menu. Closes #6674
The raw outputs don't take amplitude into account
They probably should but that will break old patches so
The text was updated successfully, but these errors were encountered: