Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FX Unit shows more clearly if you violate latency implicit guarantee #6638

Closed
baconpaul opened this issue Oct 2, 2022 · 3 comments
Closed

FX Unit shows more clearly if you violate latency implicit guarantee #6638

baconpaul opened this issue Oct 2, 2022 · 3 comments
Labels
Feature Request New feature request FX Plugin Issues pertaining to Surge XT Effects plugin Resolved Issues that have been resolved, but not merged - usually only used directly after a release
Milestone
Surge XT 1.2

Comments

@baconpaul
Copy link
Collaborator

FX Unit by default runs 0 latency and assumes a multiple of 32 block size
If you are in 0 latency mode and get a non-multiple-of-32 block you should

1: not segfault (duh) and
2: put up a message on the UI pointing people to the option for that host
@baconpaul baconpaul added the Feature Request New feature request label Oct 2, 2022
@mkruselj mkruselj added the FX Plugin Issues pertaining to Surge XT Effects plugin label Nov 5, 2022
@mkruselj mkruselj added this to the Surge XT 1.1.3 milestone Nov 7, 2022
@mkruselj
Copy link
Collaborator

mkruselj commented Jan 8, 2023

Linking this one to #6524, these two issues should have the same resolution.

@baconpaul
Copy link
Collaborator Author

the resolutions are different since the fx already has a latent option. This i just detection and handling.

baconpaul added a commit to baconpaul/surge that referenced this issue Mar 3, 2023
@baconpaul
FX Mode handles block mod buffers better
51a8500 
In the event we are in non-latent mode and our buffer is
not a multiple of block size, then

1: reset the inputs and outputs
2: Enter latent mode
3: set latency and
4: inform the host of a latency change

Addresses surge-synthesizer#6638 but some testing before we close it would be
super.
@baconpaul baconpaul mentioned this issue Mar 3, 2023
Merged
@baconpaul baconpaul added the Resolved Issues that have been resolved, but not merged - usually only used directly after a release label Mar 3, 2023
baconpaul added a commit that referenced this issue Mar 3, 2023
@baconpaul
FX Mode handles block mod buffers better (#6866)
0bb0a8a 
In the event we are in non-latent mode and our buffer is
not a multiple of block size, then

1: reset the inputs and outputs
2: Enter latent mode
3: set latency and
4: inform the host of a latency change

Addresses #6638 but some testing before we close it would be
super.
@baconpaul
Copy link
Collaborator Author

Fixed in #6866

This was referenced Mar 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature request FX Plugin Issues pertaining to Surge XT Effects plugin Resolved Issues that have been resolved, but not merged - usually only used directly after a release
Projects
None yet
Milestone
Surge XT 1.2
Development

No branches or pull requests
2 participants
@mkruselj @baconpaul