Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLAP does not respond correctly to Note On velocity 0 #6621

Closed
sagantech opened this issue Sep 21, 2022 · 2 comments · Fixed by #6624
Closed

CLAP does not respond correctly to Note On velocity 0 #6621

sagantech opened this issue Sep 21, 2022 · 2 comments · Fixed by #6624
Labels
Bug Report Item submitted using the Bug Report template CLAP Issues related to CLAP plugin format

Comments

@sagantech
Copy link
Contributor

sagantech commented Sep 21, 2022 •
edited
Loading

Bug Description:
When using CLAP version of Surge-XT (x64 and x32) and sending notes in CLAP_NOTE_DIALECT_CLAP mode, Surge-XT does not stop playing notes when it receives Note on, velocity 0 on the general channel.

Surge XT Version
1.1.1ecf7fe6

  • Version:
  • Plugin Type: CLAP
  • Bitness: both 32-bit or 64-bit]

Reproduction Steps:
Steps to reproduce the behavior:

  1. Launch Metro.
  2. Instantiate Surge
  3. From Surge UI, select patch 'Separate Ways' in polysynths category.
  4. Select "instantiated Effects/Synths" from the Metro's Windows menu.
  5. Right-click on the name "Surge Synth Team - Surge XT" and select 'Clap MIDI' from the MIDI dialect menu,
  6. Select "Keyboard" from the windows menu. Type 'ZX'

Expected Behavior:
Upon release of keys the notes should enter release phase

Computer Information (please complete the following!):

  • OS: Windows 7
  • Host:Metro
  • Version: 7.5.0.2778

Additional Information:
@baconpaul Contact me if you need more info or still need NFR.
@sagantech sagantech added the Bug Report Item submitted using the Bug Report template label Sep 21, 2022
@baconpaul
Copy link
Collaborator

Wow yeah you are totally correct!

surge/src/surge-xt/SurgeSynthProcessor.cpp

Line 603 in 1016dd7

case CLAP_EVENT_NOTE_ON:

that line needs an if velocity 0 release

I can patch that into the nightly before the weekend if no one else does it first

@mkruselj mkruselj added the CLAP Issues related to CLAP plugin format label Sep 21, 2022
@mkruselj mkruselj changed the title Surge (CLAP) does not respond correctly to Note-on velocity 0 CLAP does not respond correctly to Note On velocity 0 Sep 21, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 23, 2022
@baconpaul
Velocity 0 == note off; CLAP features
4bbbc17 
1. Velocity 0 == Note Off was not working in the CLAP_NOTE_EVENT
   stream. Correct and defensively correct in the juce stream also
   (although I think juce will have pre-converted for me)
2. Add "synthesizer" as a CLAP feature to surge xt, since surge xt
   is, in fact, a synthesizer :)

Closes surge-synthesizer#6621
@baconpaul baconpaul mentioned this issue Sep 23, 2022
Merged
baconpaul added a commit that referenced this issue Sep 23, 2022
@baconpaul
Velocity 0 == note off; CLAP features (#6624)
de315b7 
1. Velocity 0 == Note Off was not working in the CLAP_NOTE_EVENT
   stream. Correct and defensively correct in the juce stream also
   (although I think juce will have pre-converted for me)
2. Add "synthesizer" as a CLAP feature to surge xt, since surge xt
   is, in fact, a synthesizer :)

Closes #6621
@baconpaul
Copy link
Collaborator

I fixed this this morning. it will be in our next nightly release https://surge-synthesizer.github.io/nightly_XT in an hour or so. I also fixed the lack of a "synthesizer" tag while I was in there :)

Thanks for reporting it.

This was referenced Mar 5, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template CLAP Issues related to CLAP plugin format
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Velocity 0 == note off; CLAP features baconpaul/surge
3 participants
@mkruselj @baconpaul @sagantech