Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt-Arrow key is quantized but not stepped #6593

Closed
baconpaul opened this issue Sep 4, 2022 · 1 comment · Fixed by #6864
Closed

Alt-Arrow key is quantized but not stepped #6593

baconpaul opened this issue Sep 4, 2022 · 1 comment · Fixed by #6864
Labels
Accessibility Issues related to making Surge more accessible Bug Report Item submitted using the Bug Report template
Milestone

Comments

@baconpaul
Copy link
Collaborator

Chessel on discord says:

No. To go up one semitone I have to press up 8 times with control held down before it registers going up a semitone. I just noted that alt + up arrow also takes 8 up arrow presses but settles on the intermediate values as it goes up whereas control ++ up arrow stays quantized on whole values.
There is an additional querk where if you use control up arrow to go up a semitone, a single control down arrow will jump the whole semitone in one press. but further control arrow down returns to the 8 keystrokes required behaviour.

What is happening is the alt is quantizing the move but not changing the amount the move is applied. So you press up and you get jogged the same amount as if alt isn't down, but that doesn't update until you jog 'enough'. Sigh.

May be tricky to fix since that quantization jog distance isn't advertised by a param. But toss it into 112 anyway.

@baconpaul baconpaul added Bug Report Item submitted using the Bug Report template Accessibility Issues related to making Surge more accessible labels Sep 4, 2022
@baconpaul baconpaul added this to the Surge XT 1.1.2 milestone Sep 4, 2022
@baconpaul
Copy link
Collaborator Author

sigh this is really hard and we should do it differently in XT2 and SC

Basically the parameter knows its step size and the slider is 0...1 which is fine-ish but in this case it means we don't know how far to jog and don't have an API to jog up by one. The quantization happens in Parameter::set_value_f01 which calls Parameter:;bound_value

Now, Parameter::set_value_f01 doesn't require an instance really so I could set the control type onto the slider and fake up the search for the 'next' step up or down. Let me look at that. But if that hack doesn't work in the keybinding, then we are out of luck for XT1.*

baconpaul added a commit to baconpaul/surge that referenced this issue Mar 3, 2023
1. Make 'Command' the Quantized key consistently in ally and mouse
2. Actually respond to it in the modulatable slider, albeit with
   a pretty hacky way (see the comment there)
3. Fix a problem with size-one wavetables and quantized drags

Closes surge-synthesizer#6593
baconpaul added a commit that referenced this issue Mar 3, 2023
1. Make 'Command' the Quantized key consistently in ally and mouse
2. Actually respond to it in the modulatable slider, albeit with
   a pretty hacky way (see the comment there)
3. Fix a problem with size-one wavetables and quantized drags

Closes #6593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to making Surge more accessible Bug Report Item submitted using the Bug Report template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant