Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modulations custom menu entry buttons stop working after enabling "Add sub-menus for modulation entries" #6551

Closed
mkruselj opened this issue Aug 20, 2022 · 0 comments · Fixed by #7059
Closed

Modulations custom menu entry buttons stop working after enabling "Add sub-menus for modulation entries" #6551

mkruselj opened this issue Aug 20, 2022 · 0 comments · Fixed by #7059
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.3

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Aug 20, 2022 •
edited
Loading

So, we are at a crossroad. To move further, we have to choose:

  1. Hide the icons when that option is enabled (because a11y users don't care about icons anyways - easier route)
  2. Make those icons work even if the option is enabled (cooler and potentially still useful for sighted users - more work route)
@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template labels Aug 20, 2022
@mkruselj mkruselj modified the milestones: Surge XT 1.x, Surge XT 1.2.1 Apr 5, 2023
@mkruselj mkruselj changed the title Modulations menu entry icons stop working after enabling "Add sub-menus for modulation entries" Modulations custom menu entry buttons stop working after enabling "Add sub-menus for modulation entries" Apr 17, 2023
mkruselj added a commit to mkruselj/surge that referenced this issue Jun 19, 2023
@mkruselj
Hide custom mod menu entry icons when adding a11y submenu
77fa3e2 
Fixes surge-synthesizer#6551
@mkruselj mkruselj mentioned this issue Jun 19, 2023
Merged
mkruselj added a commit that referenced this issue Jun 20, 2023
@mkruselj
Hide custom mod menu entry icons when adding a11y submenu (#7059)
a8cb882 
Hide custom mod menu entry icons when adding a11y submenu
Fixes #6551
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.3
Development

Successfully merging a pull request may close this issue.

Hide custom mod menu entry icons when adding a11y submenu mkruselj/surge
2 participants
@mkruselj @baconpaul