Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace common/dsp/util/FastMath with the one from sst-filters #6532

Closed
baconpaul opened this issue Aug 19, 2022 · 3 comments · Fixed by #6943
Closed

Replace common/dsp/util/FastMath with the one from sst-filters #6532

baconpaul opened this issue Aug 19, 2022 · 3 comments · Fixed by #6943
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme DSP Issues and feature requests related to sound generation in the synth Infrastructure Issues related to repository, CI/CD, installers, etc.
Milestone
Surge XT 1.3

Comments

@baconpaul
Copy link
Collaborator

Dup otherwise
@baconpaul baconpaul added the Feature Request New feature request label Aug 19, 2022
@baconpaul baconpaul added this to the Surge XT 1.1.n milestone Aug 19, 2022
@baconpaul
Copy link
Collaborator Author

I’m gonna hold off on this one until I have more of an idea of other shared dsp which may be there with surge and sc. we may want a new SST-dsputils

@mkruselj mkruselj added DSP Issues and feature requests related to sound generation in the synth Infrastructure Issues related to repository, CI/CD, installers, etc. Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme and removed Feature Request New feature request labels Aug 20, 2022
@mkruselj mkruselj changed the title Replace common/dsp/util/FastMath with the one from set-filters Replace common/dsp/util/FastMath with the one from sst-filters Sep 8, 2022
@baconpaul
Copy link
Collaborator Author

we can live another day without doing this. the sst dsp factoring will come when we tackle scxt.

@mkruselj mkruselj modified the milestones: Surge XT 1.2, Surge XT 1.x Jan 8, 2023
@baconpaul
Copy link
Collaborator Author

OK FastMath is in basic-blocks so this is a 'double move' of the dup out of both filters and surge.

baconpaul added a commit to baconpaul/sst-filters that referenced this issue Apr 17, 2023
@baconpaul
Move to using the FastMath from BasicBlocks
6cae48d 
part of the big SC/XT refactor share project I'm chipping away
at and also aprt of surge-synthesizer/surge#6532

This will make this library depend on sst-basic-blocks (and that dependency
will get stronger as we move forward). Youc an auto-grab it with CPM if you
want.
@baconpaul baconpaul mentioned this issue Apr 17, 2023
Merged
baconpaul added a commit to surge-synthesizer/sst-filters that referenced this issue Apr 17, 2023
@baconpaul
Move to using the FastMath from BasicBlocks (#35)
5fa8539 
part of the big SC/XT refactor share project I'm chipping away
at and also aprt of surge-synthesizer/surge#6532

This will make this library depend on sst-basic-blocks (and that dependency
will get stronger as we move forward). Youc an auto-grab it with CPM if you
want.
@baconpaul baconpaul mentioned this issue Apr 17, 2023
Merged
baconpaul added a commit that referenced this issue Apr 17, 2023
@baconpaul
Move FastMath entirely to sst-basic-blocks; turn on gcc12 build (#6943)
385bb55 
FastMath is now entirely from sst-basic-blocks for both filters
and for surge.  Closes #6532
@mkruselj mkruselj modified the milestones: Surge XT 1.x, Surge XT 1.3 Apr 17, 2023
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme DSP Issues and feature requests related to sound generation in the synth Infrastructure Issues related to repository, CI/CD, installers, etc.
Projects
None yet
Milestone
Surge XT 1.3
Development

Successfully merging a pull request may close this issue.

Move FastMath entirey to sst-basic-blocks; turn on gcc12 build baconpaul/surge
2 participants
@mkruselj @baconpaul