Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Mono mode makes long release times break Mono FP. #6520

Closed
Andreya-Autumn opened this issue Aug 16, 2022 · 0 comments · Fixed by #6534
Closed

New Mono mode makes long release times break Mono FP. #6520

Andreya-Autumn opened this issue Aug 16, 2022 · 0 comments · Fixed by #6534
Labels
Bug Report Item submitted using the Bug Report template MIDI MIDI support related
Milestone
Surge XT 1.1.1

Comments

@Andreya-Autumn
Copy link
Collaborator

In Mono FP, with continue from current enabled, portamento will happen anytime sound overlaps, even if MIDI notes themselves don't overlap. This means the mode doesn't function correctly with long release times dialed in.

Mono FP+ST works as intended though.
@Andreya-Autumn Andreya-Autumn added Bug Report Item submitted using the Bug Report template MIDI MIDI support related labels Aug 16, 2022
@Andreya-Autumn Andreya-Autumn added this to the Surge XT 1.1.n milestone Aug 16, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 19, 2022
@baconpaul
Explicitly reset portamento in FP mode for stolen envs
4b5cf24 
New stolen envelope mode didn't reset portamento when
recychling a voice in mono fp mode. Rectify

Closes surge-synthesizer#6520
@baconpaul baconpaul mentioned this issue Aug 19, 2022
Merged
baconpaul added a commit that referenced this issue Aug 19, 2022
@baconpaul
Explicitly reset portamento in FP mode for stolen envs (#6534)
6cb4bcf 
New stolen envelope mode didn't reset portamento when
recychling a voice in mono fp mode. Rectify

Closes #6520
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template MIDI MIDI support related
Projects
None yet
Milestone
Surge XT 1.1.1
Development

Successfully merging a pull request may close this issue.

Explicitly reset portamento in FP mode for stolen envs baconpaul/surge
2 participants
@baconpaul @Andreya-Autumn