Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mislabeled Unarm Button #6512

Closed
baconpaul opened this issue Aug 13, 2022 · 2 comments · Fixed by #6546
Closed

Mislabeled Unarm Button #6512

baconpaul opened this issue Aug 13, 2022 · 2 comments · Fixed by #6546
Labels
Accessibility Issues related to making Surge more accessible Bug Report Item submitted using the Bug Report template
Milestone
Surge XT 1.1.1

Comments

@baconpaul
Copy link
Collaborator

When I hit the arm button for a macro I'm able to record the controller movements as my project plays. But the button is announced as "unarm button arm".Could it be made to say just "unarm button"?

from chessel
@baconpaul baconpaul added Bug Report Item submitted using the Bug Report template Accessibility Issues related to making Surge more accessible labels Aug 13, 2022
@baconpaul baconpaul added this to the Surge XT 1.1.n milestone Aug 13, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 20, 2022
@baconpaul
Invalidate 'arm' title when arming modsources
7460b57 
For accurate screen reader support, send a title changed event

Addresses surge-synthesizer#6512
@baconpaul
Copy link
Collaborator Author

So there's two reasons for this

(1) the button doesn't fire an update event which would make it say "disarm button disarm". That's corrected
(2) for some reason OP reader is reading not just the title but the title type and description. I'll push this to 1.1.x and ask in accessibility

@baconpaul baconpaul mentioned this issue Aug 20, 2022
Merged
@baconpaul
Copy link
Collaborator Author

(2) is not a surge thing it's an NVDA setting. So gonna close this when I merge above.

baconpaul added a commit that referenced this issue Aug 20, 2022
@baconpaul
Invalidate 'arm' title when arming modsources (#6546)
3f017c9 
For accurate screen reader support, send a title changed event

Addresses #6512
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Issues related to making Surge more accessible Bug Report Item submitted using the Bug Report template
Projects
None yet
Milestone
Surge XT 1.1.1
Development

Successfully merging a pull request may close this issue.

Invalidate 'arm' title when arming modsources baconpaul/surge
2 participants
@mkruselj @baconpaul