Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable or remove the dirty patches query when loading a new patch #6495

Closed
mkruselj opened this issue Aug 8, 2022 · 2 comments · Fixed by #6547
Closed

Disable or remove the dirty patches query when loading a new patch #6495

mkruselj opened this issue Aug 8, 2022 · 2 comments · Fixed by #6547
Labels
Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.1.1

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Aug 8, 2022

Now that we have undo, perhaps we don't even need this dialog at all.
@mkruselj mkruselj added Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Aug 8, 2022
@mkruselj mkruselj added this to the Surge XT 1.1.n milestone Aug 8, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 20, 2022
@baconpaul
Don't prompt for usaved patch change by default
2030fff 
Now that we have Undo it is nowhere near as pressing.
Accomplish this by setting the default to "AWLAYS" which
means always pick OK, but leaving the option and stuff in place
if people want it

Closes surge-synthesizer#6495
@baconpaul baconpaul mentioned this issue Aug 20, 2022
Merged
@mkruselj
Copy link
Collaborator Author

Tbh I kinda feel we could even remove the option...

@baconpaul
Copy link
Collaborator

I didn't want to do that much surgery. We can supress the menu if you want I guess though! But maybe some folks would like it. I dunno. Trying to keep changes "smaller" for 1.1.1

baconpaul added a commit that referenced this issue Aug 20, 2022
@baconpaul
Don't prompt for usaved patch change by default (#6547)
314514f 
Now that we have Undo it is nowhere near as pressing.
Accomplish this by setting the default to "AWLAYS" which
means always pick OK, but leaving the option and stuff in place
if people want it

Closes #6495
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.1.1
Development

Successfully merging a pull request may close this issue.

Don't prompt for usaved patch change by default baconpaul/surge
2 participants
@mkruselj @baconpaul