Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loud pops when changing filter types and subtypes #6489

Closed
erroreyes opened this issue Aug 7, 2022 · 4 comments · Fixed by #6537
Closed

Loud pops when changing filter types and subtypes #6489

erroreyes opened this issue Aug 7, 2022 · 4 comments · Fixed by #6537
Labels
Bug Report Item submitted using the Bug Report template DSP Issues and feature requests related to sound generation in the synth Have A Plan The issue has a description of how we will solve it, just we haven't done it yet
Milestone
Surge XT 1.1.1

Comments

@erroreyes
Copy link

erroreyes commented Aug 7, 2022 •
edited
Loading

Bug Description:
With a sustained note is playing, when changing filter types and subtypes, Surge XT makes loud pops, some louder than others, which is hurtful if one doesn't a) stop playback before making a change; or b) lowers the volume. In some cases, making this type of change makes a loud pop, followed by a few seconds of silence, until sound is heard again from the synth.

Surge XT Version

  • Version: SurgeXT v1.1 stable and nightly from 8/3/2022, but I have noticed this for at least a few months, across several versions.
  • Plugin Type: VST3, CLAP
  • Bitness: 64-bit

Reproduction Steps:
In Bitwig:

  1. Create a MIDI clip of any bar length
  2. Insert a MIDI note that spans the clip's bar length
  3. Load an instance of SurgeXT (CLAP or VST3)
  4. Start playback
  5. While playback is on, switch through the Lowpass options in sequence, and for each chosen option, choose a filter subtype in sequence: expected result is a "pop-less" transition; current result is that pops of varying degrees of loudness appear on playback
  6. While changing filter types as explained above, when switching from LP Vintage Ladder at subtype 4 to KS3, a loud pop occurs, followed by a few seconds of silence before audio is resumed.

Expected Behavior:
To be able to switch filter types and subtypes without audible pops that can be hurtful when using headphones, or damaging to monitor speakers.

Screenshots:
https://user-images.githubusercontent.com/107824400/183276707-1b22851f-d216-4feb-a535-f98ee67154ab.mp4

If playback appears to be corrupted, please follow the Discord link where I shared the above video, and had a short discussion on the issue.

Computer Information (please complete the following!):

  • OS: Kubuntu 22.04
  • Host: Bitwig 4.3.4 RC, Renoise 3.4.2
  • Version: See above

Additional Information:
N/A
@erroreyes erroreyes added the Bug Report Item submitted using the Bug Report template label Aug 7, 2022
@mkruselj
Copy link
Collaborator

mkruselj commented Aug 7, 2022

Probably closely related, if not identical issue to #6227.

@mkruselj mkruselj added this to the Surge XT 1.1.n milestone Aug 7, 2022
@mkruselj mkruselj added the DSP Issues and feature requests related to sound generation in the synth label Aug 7, 2022
@baconpaul
Copy link
Collaborator

Maybe but it’s more likely to be related to the int modulation in voice changes if 101 doesn’t do it

@baconpaul
Copy link
Collaborator

Yeah this is definitely caused by the local copy int in d29e67f the same way that screwed up oscillator switches on running voices. I'll revert the relevant other bits that I didn't revert from there in 110 for a 1.1.1

@baconpaul baconpaul added the Have A Plan The issue has a description of how we will solve it, just we haven't done it yet label Aug 9, 2022
@baconpaul
Copy link
Collaborator

Unison too

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 19, 2022
@baconpaul
Remediate the localcopy surgevoice errors
6da8e44 
I don't know why this didn't work, but it didn't. Use the
scene direct rather than localcopy values for filters and
the like to avoid pops and clicks when changing filters

Closes surge-synthesizer#6489
@baconpaul baconpaul mentioned this issue Aug 19, 2022
Merged
baconpaul added a commit that referenced this issue Aug 19, 2022
@baconpaul
Remediate the localcopy surgevoice errors (#6537)
09f1ec8 
* Remediate the localcopy surgevoice errors

I don't know why this didn't work, but it didn't. Use the
scene direct rather than localcopy values for filters and
the like to avoid pops and clicks when changing filters

Closes #6489

* Also fix the unison oscillator problem and LFO shape problem
which was similarly misguided, which Closes #6531
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template DSP Issues and feature requests related to sound generation in the synth Have A Plan The issue has a description of how we will solve it, just we haven't done it yet
Projects
None yet
Milestone
Surge XT 1.1.1
Development

Successfully merging a pull request may close this issue.

Remediate the localcopy surgevoice errors baconpaul/surge
3 participants
@mkruselj @baconpaul @erroreyes