Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All the side effects which are only in SurgeSynthesizer::setParameter01 #6486

Open
baconpaul opened this issue Aug 6, 2022 · 0 comments
Open

All the side effects which are only in SurgeSynthesizer::setParameter01 #6486

baconpaul opened this issue Aug 6, 2022 · 0 comments
Labels
Bug Report Item submitted using the Bug Report template Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Milestone
Surge XT 2.0

Comments

@baconpaul
Copy link
Collaborator

SurgeSynthesizer::setParameter01 is not how we set all params but it does have side effects, which leads to problems (and gross fixes) like the one in #6475

In the XT2 lifetime, review and remediate and centralize these more intelligently.
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Aug 6, 2022
@baconpaul baconpaul added this to the Surge XT 2.0 milestone Aug 6, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 6, 2022
@baconpaul
Handle F2 Offset Scene Copy and Paste Error
e4e2fe4 
F2 offset copied properly but didn't update the params correctly
so the slider had the wrong type. This is done as one of several
things and we need to review them, as discussed in surge-synthesizer#6486 but
until then, lets just do the gross thing to address this one case.

Closes surge-synthesizer#6475
@baconpaul baconpaul mentioned this issue Aug 6, 2022
Merged
baconpaul added a commit that referenced this issue Aug 6, 2022
@baconpaul
Handle F2 Offset Scene Copy and Paste Error (#6487)
eeaf676 
F2 offset copied properly but didn't update the params correctly
so the slider had the wrong type. This is done as one of several
things and we need to review them, as discussed in #6486 but
until then, lets just do the gross thing to address this one case.

Closes #6475
@mkruselj mkruselj added the Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme label Aug 9, 2022
This was referenced Mar 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Projects
None yet
Milestone
Surge XT 2.0
Development

No branches or pull requests
2 participants
@mkruselj @baconpaul