Global Volume won't modulate.

[Andreya-Autumn]

...even though it looks like it should.

In the UI, the global volume slider accepts modulation input from Macros, SLFO's or MIDI, but none of them will actually affect the output volume at all.

[baconpaul]

This problem has always been there. It is caused by this line

surge/src/common/SurgeSynthesizer.cpp

Line 4184 in beab6b1

amp.set_target_smoothed(storage.db_to_linear(storage.getPatch().volume.val.f));

which reads the parameter directly rather than the local copy / modulated value.

[baconpaul]

The plan is: fix storage.getPatch().volume.val.f to gsobalcopy[storage.getPatch().volume.id].f or similar, based on what's the actually syntax for global modulators in that file :)

[baconpaul]

oh also we probably want to up the patch version number and clear any modulations onto global volume from old patches which we don't want to suddenly work. I think? @mkruselj your view here valued.

[Andreya-Autumn]

That makes a lot of sense. If the mod didn't work in the first place obviously clearing it is the way to ensure the patches keep sounding the same.

[mkruselj]

Yup upping the patch version makes sense.

[baconpaul]

I dont want to up the patch version and change streaming response in 1.1.1 and this is neither a regression nor absolutely critical so I'm going to push it back into 1.1.x