Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oscillator undo with modulation #6379

Closed
baconpaul opened this issue Jul 18, 2022 · 0 comments · Fixed by #6407
Closed

Oscillator undo with modulation #6379

baconpaul opened this issue Jul 18, 2022 · 0 comments · Fixed by #6407
Labels
Bug Report Item submitted using the Bug Report template
Milestone
Surge XT 1.1

Comments

@baconpaul
Copy link
Collaborator

Is this known?

  1. Modulate a parameter for an oscillator
  2. Select some other oscillator type
  3. Undo
  4. Surge undoes the oscillator type but the modulation is gone
    Latest beta. Windows. Cubase.

Reported by discord user torbjorn
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Jul 18, 2022
@baconpaul baconpaul added this to the Surge XT 1.1 milestone Jul 18, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 22, 2022
@baconpaul
Undo pushes modulation when changing OSC type
e2c7e10 
Changing OSC type clears modulation. Undo now remembers the
prior mod state for undo application.

Closes surge-synthesizer#6379
@baconpaul baconpaul mentioned this issue Jul 22, 2022
Merged
baconpaul added a commit that referenced this issue Jul 22, 2022
@baconpaul
Undo pushes modulation when changing OSC type (#6407)
6da658c 
Changing OSC type clears modulation. Undo now remembers the
prior mod state for undo application.

Closes #6379
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Milestone
Surge XT 1.1
Development

Successfully merging a pull request may close this issue.

Undo pushes modulation when changing OSC type baconpaul/surge
1 participant
@baconpaul