-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find patch doesn't show selected row when clicking #6285
Comments
Yeah it used to close on select so the lack of highlight was fine. But now it stays open and that gives us new sharp edges, sepscislly when crossed with the screen reader stuff we are still working through with thst control appreciate the report Oh can’t you click the magnifier again to close it though? |
Pressing Ctrl+Enter or double clicking the row will load the patch and close the list. |
oooh have you tested that doubleclicking since the click broke? I'm not sure I coded that behavior. (If it is broken just add a mouseDoubleClick next to the mosueDown I added in the accessible row renderer) |
Oh actually I haven't tried it. Ha. |
Nope. Doubleclick doesn't close the search list, neither in Cubase nor in standalone here on Windows. Two single clicks on the search icon closes it, though. |
So the open typeahead does what you expect as you click around. Also change one cleanup path thing just to be safe Closes surge-synthesizer#6285
So the open typeahead does what you expect as you click around. Also change one cleanup path thing just to be safe Closes #6285
Bug Description:
The find patch function is very much better - thanks a lot!
But.
When left clicking on a row the patch loads fine. But the corresponding row isn't selected in the drop down menu. This means that if you subsequently try to move with the up/down keys the menu hops back to whichever row happens to be selected. If the result list is long, this gets a bit confusing.
Also (should maybe be a separate report?):
There is no logical way to close the menu with the mouse.
Surge XT Version
Version: Surge XT 1.1.nightly.190ad75
Build: 2022-06-10 @ 23:11:04 on 'WIN-OKUI4NKA6QD/pipeline' with 'MSVC-19.29.30145.0' using JUCE 6.1.6
System: Windows 64-bit VST3 on AMD Ryzen 9 3900X 12-Core Processor
Host: Steinberg Cubase @ 48.0 kHz
Computer Information (please complete the following!):
The text was updated successfully, but these errors were encountered: