Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find patch doesn't show selected row when clicking #6285

Closed
TorbjornHedberg opened this issue Jun 11, 2022 · 5 comments · Fixed by #6340
Closed

Find patch doesn't show selected row when clicking #6285

TorbjornHedberg opened this issue Jun 11, 2022 · 5 comments · Fixed by #6340
Labels
Bug Report Item submitted using the Bug Report template Host Specific Issues related to specific host(s) or host features UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@TorbjornHedberg
Copy link

Bug Description:
The find patch function is very much better - thanks a lot!

But.
When left clicking on a row the patch loads fine. But the corresponding row isn't selected in the drop down menu. This means that if you subsequently try to move with the up/down keys the menu hops back to whichever row happens to be selected. If the result list is long, this gets a bit confusing.

Also (should maybe be a separate report?):
There is no logical way to close the menu with the mouse.

Surge XT Version
Version: Surge XT 1.1.nightly.190ad75
Build: 2022-06-10 @ 23:11:04 on 'WIN-OKUI4NKA6QD/pipeline' with 'MSVC-19.29.30145.0' using JUCE 6.1.6
System: Windows 64-bit VST3 on AMD Ryzen 9 3900X 12-Core Processor
Host: Steinberg Cubase @ 48.0 kHz

Computer Information (please complete the following!):

  • OS: Windows 11
  • Host: Cubase 12
@TorbjornHedberg TorbjornHedberg added the Bug Report Item submitted using the Bug Report template label Jun 11, 2022
@baconpaul
Copy link
Collaborator

Yeah it used to close on select so the lack of highlight was fine. But now it stays open and that gives us new sharp edges, sepscislly when crossed with the screen reader stuff we are still working through with thst control

appreciate the report

Oh can’t you click the magnifier again to close it though?

@mkruselj
Copy link
Collaborator

Pressing Ctrl+Enter or double clicking the row will load the patch and close the list.

@mkruselj mkruselj added Host Specific Issues related to specific host(s) or host features UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Jun 12, 2022
@mkruselj mkruselj added this to the Surge XT 1.1 milestone Jun 12, 2022
@baconpaul
Copy link
Collaborator

oooh have you tested that doubleclicking since the click broke? I'm not sure I coded that behavior. (If it is broken just add a mouseDoubleClick next to the mosueDown I added in the accessible row renderer)

@mkruselj
Copy link
Collaborator

Oh actually I haven't tried it. Ha.

@TorbjornHedberg
Copy link
Author

Nope. Doubleclick doesn't close the search list, neither in Cubase nor in standalone here on Windows.

Two single clicks on the search icon closes it, though.

mkruselj added a commit to mkruselj/surge that referenced this issue Jun 12, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2022
So the open typeahead does what you expect as you click around.

Also change one cleanup path thing just to be safe

Closes surge-synthesizer#6285
mkruselj pushed a commit that referenced this issue Jul 10, 2022
So the open typeahead does what you expect as you click around.

Also change one cleanup path thing just to be safe

Closes #6285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Host Specific Issues related to specific host(s) or host features UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants