Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi control bug #6139

Closed
baconpaul opened this issue May 8, 2022 · 0 comments · Fixed by #6141
Closed

Midi control bug #6139

baconpaul opened this issue May 8, 2022 · 0 comments · Fixed by #6141
Labels
Bug Report Item submitted using the Bug Report template
Milestone

Comments

@baconpaul
Copy link
Collaborator

There's a bug in the latest nightly that broke my midi map. The knobs on my controller are affecting it, but it doesn't come into play until I use a control in Surge's interface to move it.
An example: I have knobs to control cutoff and resonance on both filters. Let's say res is at 0% and I turn the knob a lot. It will not actually go up, but when I focus on the control and tap up arrow, it will jump immediately to 100%.

Reports bscross on discord

@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label May 8, 2022
@baconpaul baconpaul added this to the Surge XT 1.1 milestone May 8, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue May 8, 2022
Midi Controllers go through a ControllerModulationSource
for uniform smoothing. Those CMSs are the only ones created
outside the normal modluation path, so they didn't get a sapmle
rate set which, defacto, meant only immediate mode (namely
UI) edits worked but midi edits did not.

Closes surge-synthesizer#6139
baconpaul added a commit that referenced this issue May 8, 2022
Midi Controllers go through a ControllerModulationSource
for uniform smoothing. Those CMSs are the only ones created
outside the normal modluation path, so they didn't get a sapmle
rate set which, defacto, meant only immediate mode (namely
UI) edits worked but midi edits did not.

Closes #6139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant