Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux: +/- Resize issue #600

Closed
tank-trax opened this issue Feb 14, 2019 · 1 comment · Fixed by #668
Closed

Linux: +/- Resize issue #600

tank-trax opened this issue Feb 14, 2019 · 1 comment · Fixed by #668
Labels
Linux Issues which only occur on Linux
Milestone
1.6.0

Comments

@tank-trax
Copy link
Collaborator

the minus key to the left of Backspace if pressed will Shrink the app however the plus key will not Zoom in

the - key is active whether shift is pressed or not
the + key is inactive whether shift is pressed or not
@baconpaul baconpaul added the Linux Issues which only occur on Linux label Feb 14, 2019
@baconpaul baconpaul added this to the 1.6.0 milestone Feb 26, 2019
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 26, 2019
@baconpaul
Plus key for zoom on Linux
a484e71 
Unsatisfyingly, the plus key (shift-= on US keyboards) on linux
doesn't report the character '+' to onKeyDown in VSTGUI but rather
reports '=' with shift depressed. Ideally the keyboard layer would
handle keyboard mapping of course (it does on mac) but this is a
useful enough feature and common enough keyboard mapping that I
choose to make the ugly choice to also bind shift-= to zoom increase
which defacto fixes the +/- zoom on linux.

Closes surge-synthesizer#600: +/- key on linux zoom
@baconpaul baconpaul mentioned this issue Feb 26, 2019
Merged
@baconpaul
Copy link
Collaborator

I am pretty sure I fixed this on branch baconpaul/linux-plus-zoom-600 as described in PR #668

@tank-trax don't suppose there's a chance you could test if that branch also works for you with + zooming? If so I'll merge it in. Thanks!

baconpaul added a commit that referenced this issue Feb 26, 2019
@baconpaul
Plus key for zoom on Linux (#668)
646b504 
Unsatisfyingly, the plus key (shift-= on US keyboards) on linux
doesn't report the character '+' to onKeyDown in VSTGUI but rather
reports '=' with shift depressed. Ideally the keyboard layer would
handle keyboard mapping of course (it does on mac) but this is a
useful enough feature and common enough keyboard mapping that I
choose to make the ugly choice to also bind shift-= to zoom increase
which defacto fixes the +/- zoom on linux.

Closes #600: +/- key on linux zoom
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
@baconpaul
Plus key for zoom on Linux (surge-synthesizer#668)
d6bfefc 
Unsatisfyingly, the plus key (shift-= on US keyboards) on linux
doesn't report the character '+' to onKeyDown in VSTGUI but rather
reports '=' with shift depressed. Ideally the keyboard layer would
handle keyboard mapping of course (it does on mac) but this is a
useful enough feature and common enough keyboard mapping that I
choose to make the ugly choice to also bind shift-= to zoom increase
which defacto fixes the +/- zoom on linux.

Closes surge-synthesizer#600: +/- key on linux zoom

Former-commit-id: 2e0f8c8355af0e0dbbd580266db3c3d274ecdd7b [formerly 646b504]
Former-commit-id: 3acc7f5ccc886f51d484725ea5642452864ab53d
Former-commit-id: e59ba47cf7fd9f99066b3ad9743b72d77060ba55
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Linux Issues which only occur on Linux
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Plus key for zoom on Linux baconpaul/surge
2 participants
@baconpaul @tank-trax