Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI Refresh Issue involving Alternate Mod button #5919

Closed
Brusie opened this issue Feb 28, 2022 · 1 comment · Fixed by #5921
Closed

GUI Refresh Issue involving Alternate Mod button #5919

Brusie opened this issue Feb 28, 2022 · 1 comment · Fixed by #5921
Labels
Bug Report Item submitted using the Bug Report template

Comments

@Brusie
Copy link

Brusie commented Feb 28, 2022

Bug Description:
Clicking on the Alternate mod slot makes all main mod slots bearing a default name automatically change their name: from "LFO 1" it becomes "LFO 1.1", from "S-ENV 3" becomes "S-ENV 3.1" etc. Basically adding ".1".

Surge XT Version

  • Version: Surge XT 1.1.nightly.74cac15
    Build: 2022-02-24 @ 00:17:58 on 'fv-az60-139/pipeline' with 'MSVC-19.29.30139.0' using JUCE 6.1.5
  • Plugin Type: VST3
  • Bitness: 64-bit

Reproduction Steps:
Open Surge and click on the Alternate mod slot.

Expected Behavior:
EvilDragon explained to me this should happen only with formula mod.

Screenshots:
SurgeIssue

Computer Information (please complete the following!):
System: Windows 64-bit VST3 on AMD Ryzen 5 3600 6-Core Processor
Host: Reaper @ 48.0 kHz
@Brusie Brusie added the Bug Report Item submitted using the Bug Report template label Feb 28, 2022
@baconpaul
Copy link
Collaborator

oh i bet this is because of the 3 output lfo going wrong somehow. thanks.

baconpaul added a commit to baconpaul/surge that referenced this issue Feb 28, 2022
@baconpaul
Fix an LFO label problem
a3d6db8 
"ms" not "modsource". Sigh. Used the wrong var to label the LFO.

Closes surge-synthesizer#5919
@baconpaul baconpaul mentioned this issue Feb 28, 2022
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 28, 2022
@baconpaul
Fix an LFO label problem
8768fac 
"ms" not "modsource". Sigh. Used the wrong var to label the LFO.

Closes surge-synthesizer#5919
baconpaul added a commit that referenced this issue Feb 28, 2022
@baconpaul
Fix an LFO label problem (#5921)
9c19181 
"ms" not "modsource". Sigh. Used the wrong var to label the LFO.

Closes #5919
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix an LFO label problem baconpaul/surge
2 participants
@baconpaul @Brusie