Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the sst-plugininfra defaults #5868

Closed
1 task
baconpaul opened this issue Feb 7, 2022 · 0 comments · Fixed by #5949
Closed
1 task

Use the sst-plugininfra defaults #5868

baconpaul opened this issue Feb 7, 2022 · 0 comments · Fixed by #5949
Labels
Feature Request New feature request Infrastructure Issues related to repository, CI/CD, installers, etc.
Milestone
Surge XT 1.1

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Feb 7, 2022 •
edited
Loading

I ported a templated user defaults and copied strnatcmp to the sst-plugininfra package. Lets use that in surge properly.

  • user defaults
@baconpaul baconpaul added the Feature Request New feature request label Feb 7, 2022
@baconpaul baconpaul added this to the Surge XT 1.1 milestone Feb 7, 2022
@mkruselj mkruselj added the Infrastructure Issues related to repository, CI/CD, installers, etc. label Feb 8, 2022
@baconpaul baconpaul changed the title Use the sst-plugininfra defaults Use the sst-plugininfra defaults and strnatcmp Feb 8, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Feb 13, 2022
@baconpaul
Use OS DarkMode from sst; Use strnatcmp from sst
09b6393 
sst_plugininfra provides an isDarkMode API (currently only
returning correct values on macOS). This diff does the following

1. Move the menu colors to either follow OS or follow skin
2. Since that involves an upgrade to sstplugininfra, also fix
the strnatcmp dependency, addressing surge-synthesizer#5868
@baconpaul baconpaul mentioned this issue Feb 13, 2022
Merged
baconpaul added a commit that referenced this issue Feb 13, 2022
@baconpaul
Use OS DarkMode from sst; Use strnatcmp from sst (#5887)
3e966c5 
sst_plugininfra provides an isDarkMode API (currently only
returning correct values on macOS). This diff does the following

1. Move the menu colors to either follow OS or follow skin
2. Since that involves an upgrade to sstplugininfra, also fix
the strnatcmp dependency, addressing #5868
@baconpaul baconpaul changed the title Use the sst-plugininfra defaults and strnatcmp Use the sst-plugininfra defaults Feb 22, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Mar 7, 2022
@baconpaul
Move the UserDefaults impl to the plugininfra
6bef86e 
1. Shares code more with SC and so on
2. Removes a static in place of a member
3. Gives us an option in the future to kill an API if we
   want to go from Surge::Storage::getBlah(stoarge to
   storage->userDataProvider->getBlah
4. But don't do that ehre instead forward through the functions

Closes surge-synthesizer#5868
@baconpaul baconpaul mentioned this issue Mar 7, 2022
Merged
baconpaul added a commit that referenced this issue Mar 7, 2022
@baconpaul
Move the UserDefaults impl to the plugininfra (#5949)
a7d0e4e 
* Move the UserDefaults impl to the plugininfra

1. Shares code more with SC and so on
2. Removes a static in place of a member
3. Gives us an option in the future to kill an API if we
   want to go from Surge::Storage::getBlah(stoarge to
   storage->userDataProvider->getBlah
4. But don't do that ehre instead forward through the functions

Closes #5868

* - Handle overrides
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature request Infrastructure Issues related to repository, CI/CD, installers, etc.
Projects
None yet
Milestone
Surge XT 1.1
Development

Successfully merging a pull request may close this issue.

Move the UserDefaults impl to the plugininfra baconpaul/surge
2 participants
@mkruselj @baconpaul