Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When switching between MSEGs with Movement Mode Shift Selected, the mode changes to Draw. #5841

Closed
ztnl opened this issue Jan 29, 2022 · 3 comments · Fixed by #5842
Closed

When switching between MSEGs with Movement Mode Shift Selected, the mode changes to Draw. #5841

ztnl opened this issue Jan 29, 2022 · 3 comments · Fixed by #5842
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.

Comments

@ztnl
Copy link

ztnl commented Jan 29, 2022 •
edited
Loading

Version: Surge XT 1.0.nightly.0874a1c
Build: 2022-01-28 @ 01:07:22 on 'WIN-G8OUDR116IA/pipeline' with 'MSVC-19.29.30139.0' using JUCE 6.1.2
System: Windows 64-bit VST3 on Intel(R) Core(TM) i7
Host: Reaper @ 48.0 kHz

When switching between MSEGs with Movement Mode Shift Selected, the mode changes to Draw.

To reproduce:

  1. Load MSEGs into modulation slots 1-3 for Scenes A and B.

  2. Select Movement Mode Shift for each.

  3. Notice that when switching between the other MSEGs, Movement Mode switches to Draw in both tear-in/out states.

Expected behavior is that the selected Movement Mode of Shift should persist upon switching to the other MSEGs.
@ztnl ztnl added the Bug Report Item submitted using the Bug Report template label Jan 29, 2022
@mkruselj
Copy link
Collaborator

@baconpaul This is a regression in behavior from 1.9. Maybe a nice 1.0.1 fix?

@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Jan 29, 2022
@baconpaul
Copy link
Collaborator

Oh that is me mis handling state probably. My guess is it’s too small a bug and too big a fix to sweep into the point but I will peek

@baconpaul
Copy link
Collaborator

Ahh yes i see it and the change is small. Can definitely put in 101

baconpaul added a commit to baconpaul/surge that referenced this issue Jan 29, 2022
@baconpaul
Broadcast MSEG State at correct time
8a73442 
BroadcastMSEGState should be set up at open as a close callback
but instead was called at open. Fix while retaining lfo switch
toggle.

Closes surge-synthesizer#5841
@baconpaul baconpaul mentioned this issue Jan 29, 2022
Merged
baconpaul added a commit that referenced this issue Jan 30, 2022
@baconpaul
Broadcast MSEG State at correct time (#5842)
2fa82e8 
BroadcastMSEGState should be set up at open as a close callback
but instead was called at open. Fix while retaining lfo switch
toggle.

Closes #5841
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Broadcast MSEG State at correct time baconpaul/surge
3 participants
@mkruselj @baconpaul @ztnl