Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Reset Filter Cutoff To Keytrack Root" right-click option on filter cutoff does not update UI #5814

Closed
selenologist opened this issue Jan 23, 2022 · 0 comments · Fixed by #5840
Closed

"Reset Filter Cutoff To Keytrack Root" right-click option on filter cutoff does not update UI #5814

selenologist opened this issue Jan 23, 2022 · 0 comments · Fixed by #5840
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Milestone
Surge XT 1.1

Comments

@selenologist
Copy link
Collaborator

Bug Description:
"Reset Filter Cutoff To Keytrack Root" right-click option does not update slider position.

Surge Version
Version: Surge XT 1.0.main.1edd725e
Build: 2022-01-19 @ 01:47:59 on 'rainbow/local' with 'GNU-11.1.0' using JUCE 6.1.2
System: Linux 64-bit VST3 on AMD Ryzen 7 2700X Eight-Core Processor
Host: Ardour @ 48.0 kHz

Reproduction Steps:

  1. Drag a filter cutoff slider to some position which is visibly not the keytrack root
  2. Right-click the filter cutoff slider
  3. Click "Reset Filter Cutoff To Keytrack Root"
  4. Observe that the UI does not update to reflect the new value

Expected Behavior:
UI is refreshed after this call to reflect the new value
@selenologist selenologist added the Bug Report Item submitted using the Bug Report template label Jan 23, 2022
@selenologist selenologist added this to the Surge XT 1.1 milestone Jan 23, 2022
@selenologist selenologist added the UI Issues related to UI look&feel label Jan 23, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 29, 2022
@baconpaul
Reset slider state on Keytrack state
aa81ba2 
WHen resetting a param to Filter Keytrack, make sure to reset
the slider internal state. This API remains a bit gross.

Closes surge-synthesizer#5814
@baconpaul baconpaul mentioned this issue Jan 29, 2022
Merged
baconpaul added a commit that referenced this issue Jan 29, 2022
@baconpaul
Reset slider state on Keytrack state (#5840)
e703371 
WHen resetting a param to Filter Keytrack, make sure to reset
the slider internal state. This API remains a bit gross.

Closes #5814
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.1
Development

Successfully merging a pull request may close this issue.

Reset slider state on Keytrack state baconpaul/surge
1 participant
@selenologist