Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paste Modulation can duplicate routings #5770

Closed
baconpaul opened this issue Jan 16, 2022 · 1 comment · Fixed by #5951
Closed

Paste Modulation can duplicate routings #5770

baconpaul opened this issue Jan 16, 2022 · 1 comment · Fixed by #5951
Labels
Bug Report Item submitted using the Bug Report template Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.1

Comments

@baconpaul
Copy link
Collaborator

j5v reports

Is this a bug or a feature? (I can see it being OK both ways)
Paste (modulation) targets: creates duplicates.
baconpaul — Today at 5:01 PM
oh you eman if lfo1 -> pitch and lfo2 -> pitch and you paste modulation on 2 you get lfo2 -> two pitch entries?
I think thats a bug
and one i would fix in 1.1
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Jan 16, 2022
@baconpaul baconpaul added this to the Surge XT 1.1 milestone Jan 16, 2022
@mkruselj mkruselj added Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Jan 16, 2022
@baconpaul
Copy link
Collaborator Author

confirmed the bug.

baconpaul added a commit to baconpaul/surge that referenced this issue Mar 7, 2022
@baconpaul
When copying modulation, dont make dups
b9e5456 
Used to be we would always push back so if a modulator had
the same target you ended up in an inconsistent dup state.
Check for target already in list before adding now.

Closes surge-synthesizer#5770
@baconpaul baconpaul mentioned this issue Mar 7, 2022
Merged
baconpaul added a commit that referenced this issue Mar 7, 2022
@baconpaul
When copying modulation, dont make dups (#5951)
58cfebc 
Used to be we would always push back so if a modulator had
the same target you ended up in an inconsistent dup state.
Check for target already in list before adding now.

Closes #5770
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.1
Development

Successfully merging a pull request may close this issue.

When copying modulation, dont make dups baconpaul/surge
2 participants
@mkruselj @baconpaul