Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FM Ratio Modulation Type In #5769

Closed
baconpaul opened this issue Jan 16, 2022 · 0 comments · Fixed by #5794
Closed

FM Ratio Modulation Type In #5769

baconpaul opened this issue Jan 16, 2022 · 0 comments · Fixed by #5794
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge 1.0.1

Comments

@baconpaul
Copy link
Collaborator

jv5 reports:

Tiny buglet: FM oscillator. Modulate FM Ratio from a macro. Then edit the modulation value from the right-click menu.
If you don't remove the C : prefix, the parsing fails silently and the modulation is removed.
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Jan 16, 2022
@baconpaul baconpaul added this to the Surge XT 1.1 milestone Jan 16, 2022
@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Jan 16, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 19, 2022
@baconpaul
Modulation Typein for FM Ratio Tweak
75a9785 
The modulation typein for FMRatio shows as 'C: 4.2' and if you
typed in '5' you got 5 but 'C: 5' didn't. So fix that.

Closes surge-synthesizer#5769
@baconpaul baconpaul mentioned this issue Jan 19, 2022
Merged
@baconpaul baconpaul added the Resolved Issues that have been resolved, but not merged - usually only used directly after a release label Jan 19, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 19, 2022
@baconpaul
Modulation Typein for FM Ratio Tweak
0af5c19 
The modulation typein for FMRatio shows as 'C: 4.2' and if you
typed in '5' you got 5 but 'C: 5' didn't. So fix that.

Closes surge-synthesizer#5769
baconpaul added a commit that referenced this issue Jan 22, 2022
@baconpaul
Modulation Typein for FM Ratio Tweak (#5794)
51fc0cb 
The modulation typein for FMRatio shows as 'C: 4.2' and if you
typed in '5' you got 5 but 'C: 5' didn't. So fix that.

Closes #5769
@mkruselj mkruselj modified the milestones: Surge XT 1.1, Surge 1.0.1 Jan 28, 2022
@mkruselj mkruselj removed the Resolved Issues that have been resolved, but not merged - usually only used directly after a release label Apr 29, 2022
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge 1.0.1
Development

Successfully merging a pull request may close this issue.

(XT 1.1) Modulation Typein for FM Ratio Tweak baconpaul/surge
2 participants
@mkruselj @baconpaul