Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a RMB context menu option to disable softclip in the Delay effect #5763

Closed
mkruselj opened this issue Jan 15, 2022 · 0 comments · Fixed by #5926
Closed

Add a RMB context menu option to disable softclip in the Delay effect #5763

mkruselj opened this issue Jan 15, 2022 · 0 comments · Fixed by #5926
Labels
DSP Issues and feature requests related to sound generation in the synth Effects Feature Request New feature request
Milestone
Surge XT 1.1

Comments

@mkruselj
Copy link
Collaborator

Writing this one down for @selenologist's sake so that we don't forget to implement this for XT 1.1. 😺

I suggest adding a right-click option on the Feedback slider, possibly by abusing/reusing the deform flag and then constructing relevant menu option in SurgeGUIEditorValueCallbacks (around line 1642 onward).
@mkruselj mkruselj added Feature Request New feature request DSP Issues and feature requests related to sound generation in the synth Effects labels Jan 15, 2022
@mkruselj mkruselj added this to the Surge XT 1.1 milestone Jan 15, 2022
mkruselj added a commit to mkruselj/surge that referenced this issue Mar 3, 2022
@mkruselj
Add several clipping options to Delay Feedback parameter (including n…
e92cb8c 
…one)

Closes surge-synthesizer#5763
@mkruselj mkruselj mentioned this issue Mar 3, 2022
Merged
mkruselj added a commit that referenced this issue Mar 3, 2022
@mkruselj
Add several clipping options to Delay Feedback parameter (including n…
ee01d41 
…one) (#5926)

* Add several clipping options to Delay Feedback parameter (including none)

Closes #5763
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DSP Issues and feature requests related to sound generation in the synth Effects Feature Request New feature request
Projects
None yet
Milestone
Surge XT 1.1
Development

Successfully merging a pull request may close this issue.

Add several clipping options to Delay Feedback parameter (including none) mkruselj/surge
2 participants
@mkruselj @selenologist