Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus on Typing Dismiss #5756

Closed
baconpaul opened this issue Jan 12, 2022 · 0 comments · Fixed by #6006
Closed

Focus on Typing Dismiss #5756

baconpaul opened this issue Jan 12, 2022 · 0 comments · Fixed by #6006
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.1

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Jan 12, 2022 •
edited
Loading

With #5757 we got the principle cases of focus management handled with types, but not all promptForMiniEdit
have a component naturally available, so some features like save lfo as and so on will not return focus to the right spot. Address that in 1.1.
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Jan 12, 2022
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Jan 12, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Jan 12, 2022
@baconpaul
Focus Management after Typeines
1e1581f 
Addresses surge-synthesizer#5756

When a typein is up and you dismiss it, you want focus to return
to the source. We have two codepaths to do this

- TypeinParamEditor gets a returnFocusTo and manages it
- And mini edits for rename operations
@baconpaul baconpaul mentioned this issue Jan 12, 2022
Merged
@baconpaul baconpaul modified the milestones: Surge XT 1.0, Surge XT 1.1 Jan 12, 2022
baconpaul added a commit that referenced this issue Jan 12, 2022
@baconpaul
Focus Management after Typeines (#5757)
320cd70 
Addresses #5756

When a typein is up and you dismiss it, you want focus to return
to the source. We have two codepaths to do this

- TypeinParamEditor gets a returnFocusTo and manages it
- And mini edits for rename operations
@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Jan 13, 2022
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 2, 2022
@baconpaul
Prompts all have Return Focus target
ce7b9f3 
Makes sure when you get a modal prompt and you interact with
it your focus returns to a reasonable spot. It's required for
all mini edits from now on too

Closes surge-synthesizer#5756
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 2, 2022
@baconpaul
Prompts all have Return Focus target
04a3ed2 
Makes sure when you get a modal prompt and you interact with
it your focus returns to a reasonable spot. It's required for
all mini edits from now on too

Closes surge-synthesizer#5756
@baconpaul baconpaul mentioned this issue Apr 2, 2022
Merged
baconpaul added a commit that referenced this issue Apr 2, 2022
@baconpaul
Prompts all have Return Focus target (#6006)
d4168fc 
Makes sure when you get a modal prompt and you interact with
it your focus returns to a reasonable spot. It's required for
all mini edits from now on too

Closes #5756
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.1
Development

Successfully merging a pull request may close this issue.

Prompts all have Return Focus target baconpaul/surge
2 participants
@mkruselj @baconpaul