Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise and remove manual denormal handling #5722

Closed
mkruselj opened this issue Jan 3, 2022 · 1 comment · Fixed by #5796
Closed

Revise and remove manual denormal handling #5722

mkruselj opened this issue Jan 3, 2022 · 1 comment · Fixed by #5796
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme DSP Issues and feature requests related to sound generation in the synth
Milestone
Surge XT 1.1

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Jan 3, 2022

Since we have FTZ enabled and all that, there is no need for Surge to force out denormals using clear_block_antidenormalnoise, flush_denormal and flush_sample_denormal, it seems.

In my initial tests I didn't notice any significant difference in CPU usage between current build of Surge and the one with all anti-denormals measures removed. But let's test this more and decide which of those methods should we axe specifically.
@mkruselj mkruselj added Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme DSP Issues and feature requests related to sound generation in the synth labels Jan 3, 2022
@mkruselj mkruselj added this to the Surge XT 1.1 milestone Jan 3, 2022
@mkruselj
Copy link
Collaborator Author

Link to #4900. Closing this issue fixes that one too.

mkruselj added a commit to mkruselj/surge that referenced this issue Jan 19, 2022
@mkruselj
Remove manually coded denormal handling
1457354 
Minor other cleanups (removing unused comments in a few places)

Closes surge-synthesizer#5722 and surge-synthesizer#4900
@mkruselj mkruselj mentioned this issue Jan 19, 2022
Merged
baconpaul added a commit that referenced this issue Feb 6, 2022
@mkruselj @baconpaul
Remove manually coded denormal handling (#5796)
be6dcac 
Minor other cleanups (removing unused comments in a few places)

Closes #5722 and #4900

Co-authored-by: Paul <[email protected]>
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme DSP Issues and feature requests related to sound generation in the synth
Projects
None yet
Milestone
Surge XT 1.1
Development

Successfully merging a pull request may close this issue.

Remove manually coded denormal handling mkruselj/surge
1 participant
@mkruselj