Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response from Steinberg on our first 3 issues #571

Closed
baconpaul opened this issue Feb 10, 2019 · 4 comments
Closed

Response from Steinberg on our first 3 issues #571

baconpaul opened this issue Feb 10, 2019 · 4 comments

Comments

@baconpaul
Copy link
Collaborator

Steinberg has - I think correctly - rejected 2 out of the 3 vstgui pull requests we sent in. This issue is a placeholder for a branch for me to implement their corrections and provide details as I go.
@baconpaul
Copy link
Collaborator Author

The first issue, on mouse capture, is not because the capture semantic is wrong, but because CPatchBrowser::onMouseDown does not return the correct response code. It needs to respond kMouseDownEventHandledButDontNeedMovedOrUpEvents in order to not capture. I have confirmed that with our patch removed from vstgui and the return code changed to this, the vstgui capture no longer occurs.

@baconpaul
Copy link
Collaborator Author

The second issue about character encoding is our bug not theirs. We need to make sure our patch and category names are UTF-8 encoded, which the filesystem is not in windows, so our solution as an #if WINDOWS in surge storage.

I'm getting these all together as a single PR.

@sagantech FYI - just letting you know.

@baconpaul
Copy link
Collaborator Author

Pull request #573 shows the corrections I applied to our code rather than vstgui code.

@baconpaul
Copy link
Collaborator Author

Oh and thanks to @scheffle for the patient feedback on our PRs!

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
@baconpaul
Include Steinberg PR responses (surge-synthesizer#573)
861ae0c 
We sent 3 pull requests to steinberg for vstgui and they correctly
responded that 2/3 were indicative of us not using their API correctly

As such I've removed those commits from vstgui/surge, applied the
changes to our code, and have confirmed that the two issues
(capture on mouse click and diacriticals and emojis in patch
and category names) work with the vstgui without the associated
incorrect patches.

The final patch for checmark submenus is still in vstgui.surge in
this commit

Closes surge-synthesizer#571

Former-commit-id: 3f0514eae45c05aba61804b0ac56a4a4fc1dad18 [formerly f2e59c9]
Former-commit-id: f3ae255bc2ede6a3635d1974ac019af03e9c01d7
Former-commit-id: d3f136e5f0235178709c9e4830ca0b65505c235c
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baconpaul