Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Activate individual scene outputs" option stored per instance #5657

Closed
mkruselj opened this issue Dec 21, 2021 · 1 comment · Fixed by #5924 or #5925
Closed

"Activate individual scene outputs" option stored per instance #5657

mkruselj opened this issue Dec 21, 2021 · 1 comment · Fixed by #5924 or #5925
Labels
Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.1

Comments

@mkruselj
Copy link
Collaborator

Actually I wonder if this option should maybe only be displayed for FL Studio, and just have it enabled always in other DAWs, since they don't have problems with scene outputs being active all the time and they only enable them when you route those outputs to some tracks...
@mkruselj mkruselj added Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Dec 21, 2021
@mkruselj mkruselj added this to the Surge XT 1.1 milestone Dec 21, 2021
@mkruselj mkruselj added the Code Hints Requested Someone would like to tackle this but wants a few pointers on how to start label Jan 15, 2022
@baconpaul
Copy link
Collaborator

only displaying it for FL is a reasonable idea; I would be more into suppressing it in hosts we know work though. but either way.

As to how to do this one (so I can clear the code hints requested flag). it's pretty simple

  1. The variable is called 'SurgeSynthesizer::activateExtraOutputs' and is set up from the SurgeSynthProcessor in the call to setupActivateExtraOutputs. Leave all of this unchanged. But also
  2. Add it as a variable to the dawExtraState, stream and unstream it in the storage, and use that to write back onto the synth.

Pretty straight forward. Just like editing any other synth param from the Daw Extra State. Leave the initialization path unchanged so the default is the same. Voila.

@baconpaul baconpaul removed the Code Hints Requested Someone would like to tackle this but wants a few pointers on how to start label Jan 15, 2022
@mkruselj mkruselj mentioned this issue Mar 2, 2022
Merged
mkruselj added a commit to mkruselj/surge that referenced this issue Mar 2, 2022
@mkruselj
Remove Activate individual scene outputs option altogether
be75e95 
Except leave it in for LV2.

Properly closes surge-synthesizer#5657
@mkruselj mkruselj mentioned this issue Mar 2, 2022
Merged
mkruselj added a commit that referenced this issue Mar 3, 2022
@mkruselj
Remove Activate individual scene outputs option altogether (#5925)
b2abad7 
Except leave it in for LV2.

Properly closes #5657
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.1
2 participants
@mkruselj @baconpaul