individual output problems in VST2 and VST3

[K0rrid0r]

VST2

Version: Surge XT 0.99.main.37f1e40e
Build: 2021-12-21 @ 02:15:17 on 'KORRIDOR/local' with 'MSVC-19.26.28806.0' using JUCE 6.1.2
System: Windows 32-bit VST on Intel(R) Core(TM) i7-4720HQ CPU @ 2.60GHz
Host: FruityLoops @ 44.1 kHz

Open up XT

Individual outputs are on when they shouldn't be

the individual outputs make sounds and i can turn them off and on via the menu.

when cloning a surge that had the individual outputs off will turn them on in the new clone, this is not wanted.

i cant save a state in surge nor a default preset that keep the individual outputs off.

VST3

Version: Surge XT 0.99.nightly.37f1e40
Build: 2021-12-19 @ 21:28:14 on 'fv-az102-738/pipeline' with 'MSVC-19.29.30137.0' using JUCE 6.1.2
System: Windows 32-bit VST3 on Intel(R) Core(TM) i7-4720HQ CPU @ 2.60GHz
Host: FruityLoops @ 44.1 kHz

When opening up XT VST3 individual outputs are on but they give no sound

cloning the VST3 XT also put the individual outputs on again but they actually give no sound.

[baconpaul]

This is almost definitely due to the fact that no-one ever calls setupActivateExtraOutputs anywhere!!

[baconpaul]

@K0rrid0r if you get a chance (if not i can get to it also in the next few days)

in src/surge-xt/SurgeSynthProcessor.cpp

Around line 90 are these lines

   surge->hostProgram = juce::PluginHostType().getHostDescription();
    surge->juceWrapperType = wrapperTypeString;

Immediately after them add surge->setupActivateExtraOutputs() so it will look like

    surge->hostProgram = juce::PluginHostType().getHostDescription();
    surge->juceWrapperType = wrapperTypeString;
    surge->setupActivateExtraOutputs();

and rebuild and see if it fixes the problem you see?

Forever and a day this has been a global not an instance wide property; we should make it instance level in 1.1. But right now the switch isn't ever being called.

My code is sort of apart on the floor right now otherwise i would test. If you don't get to it I can look over the next week but I think that's the fix.

[K0rrid0r]

Now it works, a new instance starts with individual outputs off, cloning works etc. Great!

[baconpaul]

Great.

[baconpaul]

(Obviously we need to merge that fix before closing tbis but thanks for test)