Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFO names not copied from Scene A to Scene B #5628

Closed
j5v opened this issue Dec 14, 2021 · 2 comments · Fixed by #5630
Closed

LFO names not copied from Scene A to Scene B #5628

j5v opened this issue Dec 14, 2021 · 2 comments · Fixed by #5630
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@j5v
Copy link
Contributor

j5v commented Dec 14, 2021

Bug Description:
When I copy from Scene A and paste into Scene B, the LFO names remain as-is in Scene B.

Surge Version
Version: Surge XT 0.99.nightly.78fd32b
Build: 2021-12-04 @ 21:39:10 on 'fv-az33-805/pipeline' with 'MSVC-19.29.30137.0' using JUCE 6.1.2
System: Windows 64-bit VST3 on Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Host: Cakewalk by Bandlab @ 44.1 kHz

Reproduction Steps:
.

Expected Behavior:
.

Screenshots:
.

Computer Information (please complete the following information):
.

Additional Information:
When implementing LFO names recently, maybe we forgot to add the LFO name structures to the clipboard copy functions. :)
@j5v j5v added the Bug Report Item submitted using the Bug Report template label Dec 14, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Dec 14, 2021
@baconpaul
Copy link
Collaborator

Oooh good catch yeah. Thanks. Tagged into XT1 milestone.

@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Dec 14, 2021
@baconpaul
Copy link
Collaborator

It also doesn't copy in scene fwiw. So name lfo1 as 'foobaz' and copy to lfo2 and the name stays 'lfo2'

baconpaul added a commit to baconpaul/surge that referenced this issue Dec 14, 2021
@baconpaul
Copy Modulator Renames in CnP operations
fb33903 
Copying scene or copying individual modulators takes the
name (including across the entire index stack) into the
copy and paste.

Closes surge-synthesizer#5628
@baconpaul baconpaul mentioned this issue Dec 14, 2021
Merged
baconpaul added a commit that referenced this issue Dec 14, 2021
@baconpaul
Copy Modulator Renames in CnP operations (#5630)
18b1087 
Copying scene or copying individual modulators takes the
name (including across the entire index stack) into the
copy and paste.

Closes #5628
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Copy Modulator Renames in CnP operations baconpaul/surge
3 participants
@mkruselj @j5v @baconpaul