Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various new tabs/multibutton states not stored in DAWstate #5588

Closed
10 tasks done
mkruselj opened this issue Dec 6, 2021 · 1 comment · Fixed by #5591
Closed
10 tasks done

Various new tabs/multibutton states not stored in DAWstate #5588

mkruselj opened this issue Dec 6, 2021 · 1 comment · Fixed by #5591
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Dec 6, 2021 •
edited
Loading

As per subject line. We store other tabs in there, so we should store these, as well. Here's what's not stored in DAWstate:

In Memory:

  • Modulation List Sort By
  • Modulation List Filter By
  • Tuning Editor Edit Mode
  • Formula Code (Modulator/Prelude)
  • Formula Debugger

Streamed

  • Modulation List Sort By
  • Modulation List Filter By
  • Tuning Editor Edit Mode
  • Formula Code (Modulator/Prelude)
  • Formula Debugger
@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template labels Dec 6, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Dec 6, 2021
@baconpaul
Copy link
Collaborator

OK have it working in memory; just need to stream it and this will get wrapped up. Soon.

baconpaul added a commit to baconpaul/surge that referenced this issue Dec 7, 2021
@baconpaul
Store state for new overlays in DES
97413fd 
DawExtraState gets state for control panels on modulator,
tuning, and formula editor

These items all stream into the DAW Extra State so it persists
across daw sessions.

Closes surge-synthesizer#5588
@baconpaul baconpaul mentioned this issue Dec 7, 2021
Merged
baconpaul added a commit that referenced this issue Dec 7, 2021
@baconpaul
Store state for new overlays in DES (#5591)
bb4998d 
DawExtraState gets state for control panels on modulator,
tuning, and formula editor

These items all stream into the DAW Extra State so it persists
across daw sessions.

Closes #5588
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Store state for new overlays in DES baconpaul/surge
2 participants
@mkruselj @baconpaul