Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-folder says 120-127, but the last bindable CC is 126. #558

Closed
esaruoho opened this issue Feb 10, 2019 · 2 comments
Closed

Sub-folder says 120-127, but the last bindable CC is 126. #558

esaruoho opened this issue Feb 10, 2019 · 2 comments

Comments

@esaruoho
Copy link
Collaborator

esaruoho commented Feb 10, 2019 •
edited
Loading

I'm experimenting with modifying the "subfolder split code" from "split by 10" to "split by 20". looks good so far, but raises weird questions:
Where's CC127? last CC is CC126.
image
@esaruoho esaruoho changed the title Sub-folder says 120-127, but the last bindable CC is 126. (And the first bindable CC is 0) Sub-folder says 120-127, but the last bindable CC is 126. Feb 10, 2019
@esaruoho
Copy link
Collaborator Author

pushing fix into branch commentsAndCC, fix looks like this
->
image

This was referenced Feb 10, 2019
Closed
Closed
esaruoho added a commit that referenced this issue Feb 10, 2019
@esaruoho
one more typo fix
c44d50d 
overall this PR closes #558
@baconpaul
Copy link
Collaborator

Fold into #566

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@esaruoho @baconpaul