Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch search typeahead vertical offset niggle only at first show/hide toggle #5574

Closed
mkruselj opened this issue Dec 6, 2021 · 3 comments · Fixed by #5586
Closed

Patch search typeahead vertical offset niggle only at first show/hide toggle #5574

mkruselj opened this issue Dec 6, 2021 · 3 comments · Fixed by #5586
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Dec 6, 2021

As showcased by this GIF:

offset

It only happens once - when closing the typeahead first time after a fresh instantiation of Surge.
@mkruselj mkruselj added UI Issues related to UI look&feel Bug Report Item submitted using the Bug Report template labels Dec 6, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Dec 6, 2021
@baconpaul
Copy link
Collaborator

OK in good (ish) news this also happens on mac at 200%

@baconpaul
Copy link
Collaborator

and found it

@mkruselj
Copy link
Collaborator Author

mkruselj commented Dec 6, 2021

👏

baconpaul added a commit to baconpaul/surge that referenced this issue Dec 6, 2021
@baconpaul
Reset Indents on SkinChange
937f10b 
We need to reset the indents on the typeahead on skin
change since it can change the font; but also since these
are set before the font change if we don't so you get a very-first-time
mis-indent setting as described in surge-synthesizer#5574

Closes surge-synthesizer#5574
@baconpaul baconpaul mentioned this issue Dec 6, 2021
Merged
baconpaul added a commit that referenced this issue Dec 6, 2021
@baconpaul
Reset Indents on SkinChange (#5586)
f017900 
We need to reset the indents on the typeahead on skin
change since it can change the font; but also since these
are set before the font change if we don't so you get a very-first-time
mis-indent setting as described in #5574

Closes #5574
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Reset Indents on SkinChange baconpaul/surge
2 participants
@mkruselj @baconpaul