Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After saving a modified patch as new patch UI is not completely refreshed to point the new patch #5570

Closed
xard-dev opened this issue Dec 6, 2021 · 2 comments · Fixed by #5592
Closed

After saving a modified patch as new patch UI is not completely refreshed to point the new patch #5570

xard-dev opened this issue Dec 6, 2021 · 2 comments · Fixed by #5592
Labels
Bug Report Item submitted using the Bug Report template Patch Browser UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@xard-dev
Copy link

xard-dev commented Dec 6, 2021 •
edited
Loading

Bug Description:
After saving a modified patch as new one the drop down menu active patch points to old patch.
Update: the favorite is not selected in the new patch but the UI does not update the state correctly.

Surge Version
Surge XT 0.99.main.007a427

  • Version:
  • Plugin Type: LV2
  • Bitness: 64-bit

Reproduction Steps:
Steps to reproduce the behavior:

  1. Open a patch to edit.
  2. Click on Save.
  3. Fill the name and modify the category.
  4. Press OK to save the patch.
  5. Open Patch drop down menu.

Expected Behavior:
The patch drop down menu points to the created patch.

Screenshots:
image

Computer Information (please complete the following information):

  • OS: Ubuntu 20.04 LTS
  • Host: Carla / Standalone
  • Version: 2.1.0
@xard-dev xard-dev added the Bug Report Item submitted using the Bug Report template label Dec 6, 2021
@xard-dev xard-dev changed the title After saving a modified patch as new one the drop down menu active patch points to old patch After saving a modified patch as new patch UI is not completely refreshed to point the new patch Dec 6, 2021
@mkruselj mkruselj added Patch Browser UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Dec 6, 2021
@baconpaul
Copy link
Collaborator

Just the checkmark is wrong, no other part of the UI, correct?

Thank you!

@baconpaul baconpaul added this to the Surge XT 1.0 milestone Dec 6, 2021
@baconpaul
Copy link
Collaborator

Anyway able to repro and confirmed. Should be an easy enough fix i hope.

baconpaul added a commit to baconpaul/surge that referenced this issue Dec 7, 2021
@baconpaul
Update patchid and category state on save
68c92b5 
When saving a patch to a new file, the patch id and current
category isn't updated so you get, well, the old one mostly!
Fix that by rescanning after a save.

Closes surge-synthesizer#5570
@baconpaul baconpaul mentioned this issue Dec 7, 2021
Merged
baconpaul added a commit that referenced this issue Dec 7, 2021
@baconpaul
Update patchid and category state on save (#5592)
8fa1338 
When saving a patch to a new file, the patch id and current
category isn't updated so you get, well, the old one mostly!
Fix that by rescanning after a save.

Closes #5570
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Patch Browser UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Update patchid and category state on save baconpaul/surge
3 participants
@mkruselj @baconpaul @xard-dev