Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long patch names can overlap with category and attribution #5564

Closed
xard-dev opened this issue Dec 6, 2021 · 7 comments · Fixed by #5571
Closed

Long patch names can overlap with category and attribution #5564

xard-dev opened this issue Dec 6, 2021 · 7 comments · Fixed by #5571
Labels
Bug Report Item submitted using the Bug Report template Patch Browser UI Issues related to UI look&feel
Milestone

Comments

@xard-dev
Copy link

xard-dev commented Dec 6, 2021

Surge Version
Surge XT 0.99.main.007a427

  • Version:
  • Plugin Type: LV2
  • Bitness: 64-bit

Reproduction Steps:
Steps to reproduce the behavior:

  1. Open preset "10 Example - Both Time And Space".

Expected Behavior:
The patch name does not overlap any other text.

Screenshots:
image

Computer Information (please complete the following information):

  • OS: Ubuntu 20.04 LTS
  • Host: Carla
  • Version: 2.1.0
@xard-dev xard-dev added the Bug Report Item submitted using the Bug Report template label Dec 6, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Dec 6, 2021
@baconpaul
Copy link
Collaborator

Oh yeah we were going to remove the word category and author in that case at least to give us some room. Thanks!

@mkruselj mkruselj changed the title XT - Long patch names can overlap with category and attribution Long patch names can overlap with category and attribution Dec 6, 2021
@mkruselj mkruselj added the UI Issues related to UI look&feel label Dec 6, 2021
@mkruselj
Copy link
Collaborator

mkruselj commented Dec 6, 2021

I'd actually reduce the font size of patch name in that case instead, if possible. ("It's just code"? 🙂 )

@baconpaul
Copy link
Collaborator

yeah so my idea was

  1. drop the pre-labels category and author
  2. if we still need space shrink the font of the patch

the only problem with 2 is it won't overlap with the typeahead replacement

@mkruselj
Copy link
Collaborator

mkruselj commented Dec 6, 2021

Can we not change the font size of both the patch name text and what's used in typeahead? I think both are justified vertically and horizontally centered across the whole height of the patch selector...

I'm really not feeling dropping the cat/by labels (at least not until XT2, but that's for a completely different reason!)...

@baconpaul
Copy link
Collaborator

PatchFont

Here we go.
That's the dynamic approach which does best it can

@baconpaul
Copy link
Collaborator

So what that does is: if it can leave the thing in place by dropping the category and by label, it does. if it can't it starts the shrinking and non-collision. I'll merge that for XT1

baconpaul added a commit to baconpaul/surge that referenced this issue Dec 6, 2021
1. If the default patcn name overlaps with category or author,
   drop the "Category: " and "By: " prefix
2. If it sitll overlaps dynamically size it and push it to top
   of box to avoid overlaps

Closes surge-synthesizer#5564
baconpaul added a commit that referenced this issue Dec 6, 2021
1. If the default patcn name overlaps with category or author,
   drop the "Category: " and "By: " prefix
2. If it sitll overlaps dynamically size it and push it to top
   of box to avoid overlaps

Closes #5564
@xard-dev
Copy link
Author

xard-dev commented Dec 6, 2021

That looks nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Patch Browser UI Issues related to UI look&feel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants