-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long patch names can overlap with category and attribution #5564
Comments
Oh yeah we were going to remove the word category and author in that case at least to give us some room. Thanks! |
I'd actually reduce the font size of patch name in that case instead, if possible. ("It's just code"? 🙂 ) |
yeah so my idea was
the only problem with 2 is it won't overlap with the typeahead replacement |
Can we not change the font size of both the patch name text and what's used in typeahead? I think both are justified vertically and horizontally centered across the whole height of the patch selector... I'm really not feeling dropping the cat/by labels (at least not until XT2, but that's for a completely different reason!)... |
So what that does is: if it can leave the thing in place by dropping the category and by label, it does. if it can't it starts the shrinking and non-collision. I'll merge that for XT1 |
1. If the default patcn name overlaps with category or author, drop the "Category: " and "By: " prefix 2. If it sitll overlaps dynamically size it and push it to top of box to avoid overlaps Closes surge-synthesizer#5564
1. If the default patcn name overlaps with category or author, drop the "Category: " and "By: " prefix 2. If it sitll overlaps dynamically size it and push it to top of box to avoid overlaps Closes #5564
That looks nice! |
Surge Version
Surge XT 0.99.main.007a427
Reproduction Steps:
Steps to reproduce the behavior:
Expected Behavior:
The patch name does not overlap any other text.
Screenshots:
Computer Information (please complete the following information):
The text was updated successfully, but these errors were encountered: