Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod list doesn't use proper mod f01 depth #5562

Closed
mkruselj opened this issue Dec 6, 2021 · 3 comments · Fixed by #5568
Closed

Mod list doesn't use proper mod f01 depth #5562

mkruselj opened this issue Dec 6, 2021 · 3 comments · Fixed by #5568
Labels
Bug Report Item submitted using the Bug Report template Modulation Modulation related issues UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Dec 6, 2021

image
image
@mkruselj mkruselj added UI Issues related to UI look&feel Modulation Modulation related issues Bug Report Item submitted using the Bug Report template labels Dec 6, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Dec 6, 2021
@baconpaul
Copy link
Collaborator

Huh tbis should use the exact same code as the infowindow display - interresting

@baconpaul
Copy link
Collaborator

So this is the exact same code as the infowindow
and the info window doesn't show units for the bounds

but the problem isn't units; its that i'm not converting from f01 to native properly so real bug here

Check out the discrepancy between the info window and the moldiest for pitch here.

Screen Shot 2021-12-06 at 8 00 58 AM

@baconpaul baconpaul changed the title Mod list doesn't use proper parameter units for mod depth Mod list doesn't use proper mod f01 depth Dec 6, 2021
@baconpaul
Copy link
Collaborator

Screen Shot 2021-12-06 at 8 04 31 AM

And fixed!

baconpaul added a commit to baconpaul/surge that referenced this issue Dec 6, 2021
@baconpaul
Use correctly scaled modulation dept for display
45728f4 
We were using getModulation not getModDepth which is the
difference between the scaled and 01 apis, so mod list was
inconsistent display with infowindow.

Closes surge-synthesizer#5562
This was referenced Dec 6, 2021
Merged
Closed
baconpaul added a commit that referenced this issue Dec 6, 2021
@baconpaul
Use correctly scaled modulation dept for display (#5568)
5873a27 
We were using getModulation not getModDepth which is the
difference between the scaled and 01 apis, so mod list was
inconsistent display with infowindow.

Closes #5562
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Modulation Modulation related issues UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Use correctly scaled modulation dept for display baconpaul/surge
2 participants
@mkruselj @baconpaul