Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portamento in octave-per-channel mode starts from wrong octave when starting from all notes off #5503

Closed
cgibbard opened this issue Nov 26, 2021 · 1 comment · Fixed by #5508
Labels
Bug Report Item submitted using the Bug Report template

Comments

@cgibbard
Copy link
Contributor

Bug Description:
In octave-per-channel mode with any portamento, it seems as though the last played note when all notes are off is always treated as if it were on channel 1 (or 0 depending on how you count), so if you set a long portamento time and play separated notes on channel 3, say, you'll hear the pitch rise up slowly from way down in the bass.

Surge Version
main e5d4b4c

Reproduction Steps:
Steps to reproduce the behavior:
Set init sine, set portamento to some long time like 1 to 4 seconds, apply tuning at MIDI input, use channel for octave shift. This seems to happen even in poly mode, as well as mono, mono st, mono fp.

Play note 0 on channel 3 a few times.

Expected: Hear only the pitch that note 0 on channel 3 makes, or possibly a slide from some other pitch initially, but thereafter only that note.

Actual: Each new note slides up from the pitch of note 0 a couple octaves below.

If you switch between different notes, you'll notice that it starts on the octave equivalent of the last played note, but in the wrong octave.

@cgibbard cgibbard added the Bug Report Item submitted using the Bug Report template label Nov 26, 2021
@baconpaul
Copy link
Collaborator

This is basically adding a map octave if statement the same way I added an mts fix in d0623d8

baconpaul added a commit to baconpaul/surge that referenced this issue Nov 26, 2021
In OPC mode the same repeated portamento starting point
as with MTS was in play. Fix it in the same spot and add
a test.

Closes surge-synthesizer#5503
baconpaul added a commit that referenced this issue Nov 26, 2021
In OPC mode the same repeated portamento starting point
as with MTS was in play. Fix it in the same spot and add
a test.

Closes #5503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants