Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portamento issues with larger scales (31edo) low/high note priority and channel per octave #5492

Closed
cgibbard opened this issue Nov 25, 2021 · 1 comment · Fixed by #5502
Closed
Labels
Bug Report Item submitted using the Bug Report template Tuning Non-standard tuning extensions
Milestone

Comments

@cgibbard
Copy link
Contributor

Bug Description:
Sometimes the note which is picked to switch to after a note-off isn't the right one. See the repro steps.

Surge Version
main

Reproduction Steps:
Steps to reproduce the behavior:
Set mono st, high note prio, apply tuning at midi input, channel per octave, load 31edo.scl.
Play note-on 29 channel 2, note-on 3 channel 3, note-on 8 channel 3, note-off 8 channel 3.
Expected: hear note 3 channel 3
Actual: hear note 29 channel 2.

And another:
This time in low note prio, but same other settings
Play note-on 0 channel 3, note-on 26 channel 2, note-on 21 channel 2, note-off 21 channel 2
Expected: hear 21 channel 2
Actual: hear 0 channel 3.

@cgibbard cgibbard added the Bug Report Item submitted using the Bug Report template label Nov 25, 2021
@mkruselj mkruselj added the Tuning Non-standard tuning extensions label Nov 25, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Nov 25, 2021
@baconpaul
Copy link
Collaborator

got it

baconpaul added a commit to baconpaul/surge that referenced this issue Nov 26, 2021
1. Fix another mono voice stealing problem. Closes surge-synthesizer#5492
2. Fix a "RETUNE_ALL" problem. Closes surge-synthesizer#5477
baconpaul added a commit that referenced this issue Nov 26, 2021
1. Fix another mono voice stealing problem. Closes #5492
2. Fix a "RETUNE_ALL" problem. Closes #5477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Tuning Non-standard tuning extensions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants