Glissando Retrigger Tuning Behavior

[baconpaul]

Related finding for both microtuning modes: With Glissando and Retrigger At Scale Degrees checked, the degrees appear to be related to 12-equal. Tested with ED2-31 and a glide across 31 MIDI Notes, plays 12 retriggered notes.

In RETUNE_AT_MIDI/MTS mode portamento is in key space so retrievers when you run over a key. If you work in RETUNE_AFTER_MODULATION it should work. But we should open a separate issue, since I have this particular one closed. I'll do that now.

This one has been there since 1.9; it may be tricky to fix. The code in question is this

 if (scene->portamento.porta_retrigger)
            if (floor(state.pkey + 0.5) != state.priorpkey)
            {
                state.priorpkey = floor(state.pkey + 0.5);
                state.porta_doretrigger = true;
            }

which in retune at midi and its mode has to be retuned-key-aware not key-aware

@ztnl

[baconpaul]

OK this one turns out to be a bit tricky because there's a hard calculation to do

basically in MTS/Retun@Midi it sweeps keyboard in 12tet space and remaps keys
That means I need to do the calculation of: for this 12tet key what's the underlying midi note key.
That's an inverse lookup (this frequency is between these notes in the scale)
and since the scale isn't monotonic my only choice is really a roughly linear search
but luckily i have the prior starting point
just some tricky code
and tricky code i have to write differently for MTS than native

let me see if i can make native work first.

[baconpaul]

OK got it
it is slightly inefficient but has to be that way alas.