Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula Modulator Subscriptions Crash #5473

Closed
baconpaul opened this issue Nov 24, 2021 · 0 comments · Fixed by #5479
Closed

Formula Modulator Subscriptions Crash #5473

baconpaul opened this issue Nov 24, 2021 · 0 comments · Fixed by #5479
Labels
Bug Report Item submitted using the Bug Report template
Milestone

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Nov 24, 2021

function init(modstate)
    -- this function is called at the creation of each LFO (so voice on etc...)
    -- and allows you to adjust the modstate with pre-calculated values
    modstate["subscriptions"]["macros"] = true 
    return modstate
end

function process(modstate)
    -- this is the per-block'process'. input will contain keys 'phase' 'intphase',
    -- 'deform'. You must set the output value and return it. See the manual or
    -- tutorials for more

    modstate["output"] = modstate["phase"] * 2 - 1
    return modstate
end

This will crash surge every time because the macros has gone to true. Should give a proper error instead or just deal.

@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Nov 24, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Nov 24, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 25, 2021
While in there, let you bulk-subscribe too

Closes surge-synthesizer#5473
baconpaul added a commit that referenced this issue Nov 25, 2021
While in there, let you bulk-subscribe too

Closes #5473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant