Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why changing top window border color doesn't work when changing skins #5447

Closed
mkruselj opened this issue Nov 22, 2021 · 1 comment · Fixed by #5451
Closed

Investigate why changing top window border color doesn't work when changing skins #5447

mkruselj opened this issue Nov 22, 2021 · 1 comment · Fixed by #5451
Labels
Bug Report Item submitted using the Bug Report template Standalone Issues pertaining to Surge standalone application and CLI (command line interface) UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Nov 22, 2021 •
edited
Loading

Just switch between Classic/Dark/Royal in standalone and you can see the border color of the standalone doesn't change even if it should (see SurgeSynthEditor.cpp, L221-235).

It does change if you restart (of course).
@mkruselj mkruselj added UI Issues related to UI look&feel Bug Report Item submitted using the Bug Report template Standalone Issues pertaining to Surge standalone application and CLI (command line interface) labels Nov 22, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Nov 22, 2021
@baconpaul
Copy link
Collaborator

I think there’s a widget in the hierarchy which is a resizable thingy and that’s what we need to get

baconpaul added a commit to baconpaul/surge that referenced this issue Nov 23, 2021
@baconpaul
Change top level window borders on skin changes
5ad222e 
Basically just calling the right thing at the right time just
annoyingly correctly as opposed to lcose-to-correctly like
we were

Closes surge-synthesizer#5447
@baconpaul baconpaul mentioned this issue Nov 23, 2021
Merged
baconpaul added a commit that referenced this issue Nov 23, 2021
@baconpaul
Change top level window borders on skin changes (#5451)
f0a5482 
Basically just calling the right thing at the right time just
annoyingly correctly as opposed to lcose-to-correctly like
we were

Closes #5447
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Standalone Issues pertaining to Surge standalone application and CLI (command line interface) UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Change top level window borders on skin changes baconpaul/surge
2 participants
@mkruselj @baconpaul